Repository navigation
fix(server): issue URLs with an unconfigured port no longer resolve to the default-port server #38010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StiensWout
wants to merge
9
commits into
pingdotgg:main
Choose a base branch
from
StiensWout:t3/1058-issue-urls-with-an-unconfigured-port-res
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+171
−61
Open
fix(server): issue URLs with an unconfigured port no longer resolve to the default-port server #38010
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0c68193
test(server): an issue URL on an unconfigured port resolves to no pro…
StiensWout 5308c16
fix(server): issue URLs with an unconfigured port no longer resolve t…
StiensWout 0d9bbd4
fix(issues): match URL ports against repository identity
StiensWout 2057664
fix(client): match issue links against configured web authority
StiensWout fa94e7c
fix(server): preserve issue binding hosts across authority matching
StiensWout d1bb526
fix(issues): prefer configured authorities over SSH host fallbacks
StiensWout 7f89b34
fix(issues): preserve SSH candidates for default-port links
StiensWout 75f2424
chore: credit the models that worked on this change
StiensWout b9d53b1
test(server): trim issue URL authority cases to the matching behavior
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Route GitLab issue requests to the configured port.
An accepted issue URL on a configured GitLab port resolves to the portless binding host.
resolveUrlreturnslender.host, and that value is the GitLab binding host fromchangeRequestHost, which drops the port forgitlab.GitLabClithen sends the request withGITLAB_HOSTset to that portless value, and it does not recover the port from the checkout. Reads and comments for that link can therefore target the default-port GitLab instance rather than the instance that serves the URL. Those requests can read or write a different server's issue with the same number.The binding that drops the port is the fallback path in
packages/source-control-core/src/shared/definition.ts(around lines 917-918). The request host is set inpackages/source-control-gitlab/src/server/GitLabCli.ts(around line 495). The fix needs to keep the configured authority for GitLab requests while preserving the binding semantics. Changing the binding also means updating thegitlabexpectation inpackages/client-runtime/src/sourceControlClients.test.ts(lines 346-348).