Repository navigation
fix(server): MCP OAuth grants no more than the scope the client asked for #38339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+234
−16
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
de124b7
fix(server): MCP OAuth grants no more than the scope the client asked…
Echways fe867d7
fix(web): MCP consent clamps access to the app's requested read-only …
Echways d41628a
test(server): in-process MCP OAuth read-scope test runs on the test c…
Echways 26f481a
fix(auth): merge main into requested-scope fix
maria-rcks bc2f010
fix(auth): align OAuth test clock and translate scope ceiling
maria-rcks acd28f9
fix(auth): hide write-only tools from read-only mcp clients
maria-rcks c1857c2
test(mcp): assert read-only write denial codes
Echways File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the no-scope pairing-code case in the existing test.
The existing pairing-code test already exchanges a no-scope authorization code and checks that the client receives Auto access. This assertion repeats that path. Extend the existing test with the new scope variants, and keep its replay and token-audience checks. Keep the browser-session case separate because it exercises a different approval path. (raw.githubusercontent.com)
As per coding guidelines, “Extend before you add. When an existing test or table covers the behavior, add a row or an assertion there.” As per path instructions, “Test at the lowest layer that fails on main and avoid duplicate coverage.”
Sources: Coding guidelines, Path instructions