Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,13 @@ it("names a linked pull request row by its kind, number and title, not its URL",
expect(name).toMatch(/pull request/i);
expect(name).toContain("#1");
expect(name).toContain("Test PR");
const exposedNumbers = [...screen.container.querySelectorAll("span")].filter(
(span) =>
span.textContent?.trim() === "#1" &&
span.closest("button") === null &&
span.closest('[aria-hidden="true"]') === null,
);
expect(exposedNumbers).toHaveLength(0);
});

it("names a linked issue row by its kind, number and title, not its URL", async () => {
Expand Down
4 changes: 3 additions & 1 deletion apps/web/src/components/chat/ThreadDetailsPrRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,9 @@ export function ThreadDetailsPrRow({
<div className="pb-1.5">
{openRow(detail.title, "row", true)}
<div className="flex h-5 min-w-0 items-center gap-0.5 ps-9 pe-2.5 text-xs text-muted-foreground">
<span className="me-1 shrink-0 tabular-nums">#{number}</span>
<span aria-hidden className="me-1 shrink-0 tabular-nums">
#{number}
</span>
{showChecks && checksRollup !== null ? (
<PullRequestChecksPopover
checksState={checksRollup}
Expand Down
Loading