Repository navigation
fix(mobile): A document whose upload failed can be retried in the composer #38443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 3 commits into
pingdotgg:main
from
mwolson:fix/mobile-document-upload-retry
Nov 18, 2026
+28
−9
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
f5655ff
fix(mobile): A document whose upload failed can be retried in the com…
mwolson 6449587
Merge remote-tracking branch 'origin/main' into fix/mobile-document-u…
juliusmarminge 4c9c677
fix(mobile): pad document tiles only while an upload badge covers them
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep a document tile visible while its retry uploads.
composerStripAttachmentskeeps a non-media document only while its upload status isfailed. Once Retry moves the document to an in-progress status, the filter removes it fromstripAttachmentsinThreadComposer.tsx. The tile, its progress badge, and the Retry control then disappear for the whole upload, so users cannot see that the retry is running.The tile should stay visible from failure until the upload succeeds. The predicate that keeps documents in the strip should cover in-progress uploads as well as failed ones. The tile should be removed only after success. The choice of predicate and how success clears the upload state is left to the author.
Extend the existing
composerStripAttachmentscase with a document in an uploading state. The current test covers only the failed state, so it does not catch this regression.