Repository navigation
fix(server): usage-limit recovery survives notification wakes that did no work #38498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yspreen
wants to merge
8
commits into
pingdotgg:main
Choose a base branch
from
yspreen:fix/usage-limit-recovery-notification-wakes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,052
−27
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e1d0997
fix(server): usage-limit recovery survives notification wakes that di…
yspreen a48acae
fix(client-runtime): paging back shows the limit error and wake notif…
yspreen 2c0aaad
test(server): drop bounded-window assertion covered by threadHistoryP…
juliusmarminge fab462e
fix(server): continuations and user runs never count as usage-limit w…
juliusmarminge 99bd045
perf(server): read wake inputs only for usage-limit wake candidates
juliusmarminge 536d156
fix(server): a run on another provider is never a usage-limit wake
juliusmarminge 6d9f8c6
fix(server): bounded recovery evidence stays compact and matches the …
yspreen 57c8988
fix(server): a notification run that did work is never a usage-limit …
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for work without loading the full turn transcript.
A notification-started run can complete before reset after producing a large tool transcript. This read decodes every item for that run on each subsequent command projection, even though one work item is enough to rule it out as a no-work wake. The SQL recovery selector already uses an existence check for the same predicate. (raw.githubusercontent.com)
Return the IDs of candidates with work from a narrow store query. Keep the first-input check so a notification steer does not classify a user-started run as a wake. As per coding guidelines, “Make sure all changes are considerate of performance impact.”
Source: Coding guidelines