Repository navigation
fix(server): preview snapshots of large pages no longer starve their own screenshot #38618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jayden-FGH
wants to merge
2
commits into
pingdotgg:main
Choose a base branch
from
Jayden-FGH:fix/preview-snapshot-large-tree
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not start the accessibility tree for a snapshot that a newer snapshot has superseded.
runSnapshotadvancessnapshotTurnsbeforecapturebegins.capturereads metrics before it invalidates refs at line 711, so a newer snapshot can exist while the older one still passes the generation check at line 761. The older snapshot then startsariaSnapshot. That tree can occupy the renderer's main thread and delay the newer snapshot's metrics read until its deadline.Pass the turn from
runSnapshotintocapture. Check that the page's turn still matches before the tree starts, in addition to the existing deadline and generation checks. Decide how the superseded snapshot ends. The retry path already stops retrying when a newer turn exists, so the first attempt should follow a consistent rule. Keep the generation check for navigation and ref invalidation.Add a focused test that holds the newer snapshot's metrics response while the older snapshot's screenshot resolves. The test should assert that the older snapshot does not start the accessibility tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this can happen. I have left it out of this PR: the overlap predates it (an older capture can pass its metrics read on
mainafter a newer one has begun), though waiting for the screenshot does widen the window, and the PR body lists it under "Not checked". It needs the turn threaded intocaptureand a two-capture test, so it is a second problem under the one-problem rule. Happy to send it separately if a maintainer wants it.