Skip to content
2 changes: 2 additions & 0 deletions apps/server/src/provider/Drivers/AntigravityDriver.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ const makeHarness = Effect.fn("makeAntigravityDriverHarness")(function* (
config: { ...AntigravityDriver.defaultConfig(), ...options.config },
environment: [
{ name: "PATH", value: instancePath },
// Keep the developer's ~/.gemini skills and plugins out of the profile.
{ name: "HOME", value: path.join(root, "home") },
{ name: "T3_ACP_ANTIGRAVITY", value: "1" },
{ name: "T3_ACP_REQUEST_LOG_PATH", value: requestLog },
{ name: "GEMINI_API_KEY", value: "must-not-be-used" },
Expand Down
6 changes: 5 additions & 1 deletion apps/server/src/provider/Drivers/AntigravityDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,10 @@ export const AntigravityDriver: ProviderDriver<
probeUsage: usage.probe,
clearUsage: usage.clear,
auth: { type: auth.authMethod, label: antigravityAuthLabel(auth.authMethod) },
supportsTextGeneration: isAntigravityTextGenerationAvailable(profileDirectory).pipe(
supportsTextGeneration: isAntigravityTextGenerationAvailable({
profileDirectory,
userHome,
}).pipe(
Effect.provideService(FileSystem.FileSystem, fileSystem),
Effect.provideService(Path.Path, path),
Effect.orElseSucceed(() => false),
Expand Down Expand Up @@ -621,6 +624,7 @@ export const AntigravityDriver: ProviderDriver<
});
const textGeneration = yield* makeAntigravityTextGeneration({
profileDirectory,
userHome,
defaultModel,
withProcess: authFlow.withProcess,
makeRuntime: (cwd) =>
Expand Down
115 changes: 113 additions & 2 deletions apps/server/src/provider/Drivers/AntigravitySkills.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,20 +107,131 @@ it.layer(NodeServices.layer)("discoverAntigravitySkills", (it) => {
`---\nname: ${plugin}-skill\ndescription: From ${plugin}.\n---\n`,
);
}
for (const plugin of ["default-off", "opted-in"]) {
yield* writeSkill(
path.join(plugins, plugin, "skills", `${plugin}-skill`),
`---\nname: ${plugin}-skill\n---\n`,
);
yield* fileSystem.writeFileString(
path.join(plugins, plugin, "plugin.json"),
'{"disabled":true}',
);
}
yield* fileSystem.writeFileString(
path.join(profileDirectory, "config", "config.json"),
JSON.stringify({ plugins: { off: { enabled: false } } }),
JSON.stringify({ plugins: { off: { enabled: false }, "opted-in": { enabled: true } } }),
);
yield* fileSystem.writeFileString(path.join(plugins, ".DS_Store"), "x");
const input = { ...workspace, profileDirectory };

assert.deepEqual(
(yield* discoverAntigravitySkills(input)).map((skill) => skill.name),
["demo-skill"],
["demo-skill", "opted-in-skill"],
);
}),
);

it.effect("skips an oversized profile config.json when no plugins are installed", () =>
Effect.gen(function* () {
const fileSystem = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
const input = yield* makeWorkspace();
const userSkill = yield* writeSkill(
path.join(input.userHome, ".gemini", "config", "skills", "user"),
"---\nname: user\n---\n",
);
const projectSkill = yield* writeSkill(
path.join(input.cwd, ".agents", "skills", "project"),
"---\nname: project\n---\n",
);
yield* fileSystem.makeDirectory(path.join(input.profileDirectory, "config"), {
recursive: true,
});
yield* fileSystem.writeFileString(
path.join(input.profileDirectory, "config", "config.json"),
" ".repeat(1_000_001),
);

assert.deepEqual(yield* discoverAntigravitySkills(input), [
{ name: "project", path: projectSkill, scope: "project", enabled: true },
{ name: "user", path: userSkill, scope: "user", enabled: true },
]);
}),
);

it.effect.skipIf(!symlinksSupported)(
"reads skills from enabled user plugins before the profile links them",
() =>
Effect.gen(function* () {
const fileSystem = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
const input = yield* makeWorkspace();
const config = path.join(input.userHome, ".gemini", "config");
const profileConfig = path.join(input.profileDirectory, "config");
for (const [plugin, manifest, text] of [
["on", "plugin.json"],
["ag", ".antigravity-plugin/plugin.json"],
["gem", ".gemini-plugin/plugin.json"],
["off", "plugin.json"],
["bare", undefined],
["profile-off", "plugin.json"],
["shadowed", "plugin.json"],
["invalid", "plugin.json", "{"],
["string-flag", "plugin.json", '{"disabled":"yes"}'],
["null-flag", "plugin.json", '{"disabled":null}'],
["default-off", "plugin.json", '{"disabled":true}'],
["re-enabled", ".gemini-plugin/plugin.json", '{"disabled":true}'],
["profile-blocked", "plugin.json", '{"disabled":true}'],
] as const) {
const directory = path.join(config, "plugins", plugin);
yield* writeSkill(path.join(directory, "skills", plugin), `---\nname: ${plugin}\n---\n`);
if (manifest !== undefined) {
yield* fileSystem.makeDirectory(path.dirname(path.join(directory, manifest)), {
recursive: true,
});
yield* fileSystem.writeFileString(path.join(directory, manifest), text ?? "{}");
}
}
yield* fileSystem.writeFileString(
path.join(config, "config.json"),
JSON.stringify({
plugins: {
off: { enabled: false },
"re-enabled": { enabled: true },
"profile-blocked": { enabled: true },
},
}),
);
yield* writeSkill(
path.join(profileConfig, "plugins", "shadowed", "skills", "own"),
"---\nname: profile-shadowed\n---\n",
);
yield* fileSystem.writeFileString(
path.join(profileConfig, "config.json"),
JSON.stringify({
plugins: { "profile-off": { enabled: false }, "profile-blocked": { enabled: false } },
}),
);
// A link from before "off" was disabled goes on the next launch.
yield* fileSystem.symlink(
path.join(config, "plugins", "off"),
path.join(profileConfig, "plugins", "off"),
);

assert.deepEqual(
(yield* discoverAntigravitySkills(input)).map((skill) => [skill.name, skill.scope]),
[
["ag", "user"],
["gem", "user"],
["null-flag", "user"],
["on", "user"],
["profile-shadowed", "user"],
["re-enabled", "user"],
],
);
}),
);

it.effect("uses native root order for duplicate names", () =>
Effect.gen(function* () {
const fileSystem = yield* FileSystem.FileSystem;
Expand Down
172 changes: 141 additions & 31 deletions apps/server/src/provider/Drivers/AntigravitySkills.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ const decodePluginPreferences = Schema.decodeUnknownOption(
}),
),
);
const decodePluginManifest = Schema.decodeUnknownOption(
// agy decodes like Go's encoding/json, so null leaves the default and a string is invalid.
Schema.fromJsonString(
Schema.Struct({ disabled: Schema.optional(Schema.NullOr(Schema.Boolean)) }),
),
);

export class AntigravitySkillsProbeError extends Schema.TaggedError<AntigravitySkillsProbeError>()(
"AntigravitySkillsProbeError",
Expand Down Expand Up @@ -104,6 +110,139 @@ const readIfPresent = <A, R>(
}),
);

/** Reads a file of at most MAX_SKILL_BYTES, or undefined when it is missing. */
export const readAntigravityBoundedFile = Effect.fn("readAntigravityBoundedFile")(function* (
filePath: string,
) {
const fileSystem = yield* FileSystem.FileSystem;
const info = yield* readIfPresent(fileSystem.stat(filePath), filePath);
if (info?.type !== "File") return undefined;
if (info.size > BigInt(MAX_SKILL_BYTES)) {
return yield* new AntigravitySkillsProbeError({
reason: "scan-budget-exhausted",
path: filePath,
});
}
return yield* readIfPresent(fileSystem.readFileString(filePath), filePath);
});

/** The explicit `plugins.<name>.enabled` values in a GEMINI_HOME's config.json. */
const readAntigravityPluginPreferences = Effect.fn("readAntigravityPluginPreferences")(function* (
configPath: string,
) {
const config = yield* readAntigravityBoundedFile(configPath);
const preferences = config === undefined ? undefined : decodePluginPreferences(config);
return new Map(
Object.entries(
(preferences?._tag === "Some" ? preferences.value.plugins : undefined) ?? {},
).flatMap(([name, plugin]) =>
plugin.enabled === undefined ? [] : [[name, plugin.enabled] as const],
),
);
});

/** agy skips a plugin folder without one of these manifests, or whose manifest is not valid JSON. */
const ANTIGRAVITY_PLUGIN_MANIFESTS = [
"plugin.json",
".antigravity-plugin/plugin.json",
".gemini-plugin/plugin.json",
] as const;

const readAntigravityPluginManifest = Effect.fn("readAntigravityPluginManifest")(function* (
pluginDirectory: string,
) {
const path = yield* Path.Path;
for (const manifest of ANTIGRAVITY_PLUGIN_MANIFESTS) {
const text = yield* readAntigravityBoundedFile(path.join(pluginDirectory, manifest));
if (text === undefined) continue;
const decoded = decodePluginManifest(text);
return decoded._tag === "Some" ? { disabled: decoded.value.disabled === true } : undefined;
}
return undefined;
});

/** A plugin shipping `"disabled": true` loads only when config.json enables it by folder name. */
const isAntigravityPluginEnabled = (disabledByDefault: boolean, enabled: boolean | undefined) =>
disabledByDefault ? enabled === true : enabled !== false;

/** Enabled plugins in the user's ~/.gemini, by name, that a profile links and agy then loads. */
export const readAntigravityUserPlugins = Effect.fn("readAntigravityUserPlugins")(function* (
userHome: string,
) {
const fileSystem = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
const pluginsDirectory = path.join(userHome, ".gemini", "config", "plugins");
const plugins = new Map<
string,
{ readonly directory: string; readonly disabledByDefault: boolean }
>();
const names = yield* readIfPresent(fileSystem.readDirectory(pluginsDirectory), pluginsDirectory);
for (const name of names?.toSorted() ?? []) {
const directory = path.join(pluginsDirectory, name);
const info = yield* readIfPresent(fileSystem.stat(directory), directory);
if (info?.type !== "Directory") continue;
const manifest = yield* readAntigravityPluginManifest(directory);
if (manifest === undefined) continue;
plugins.set(name, { directory, disabledByDefault: manifest.disabled });
}
if (plugins.size === 0) return plugins;
const preferences = yield* readAntigravityPluginPreferences(
path.join(userHome, ".gemini", "config", "config.json"),
);
for (const [name, plugin] of plugins) {
if (!isAntigravityPluginEnabled(plugin.disabledByDefault, preferences.get(name))) {
plugins.delete(name);
}
}
return plugins;
});

/** Plugins agy loads from the profile once its next launch relinks the enabled user plugins. */
export const readAntigravityPlugins = Effect.fn("readAntigravityPlugins")(function* (input: {
readonly profileDirectory: string;
readonly userHome: string;
}) {
const fileSystem = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
const pluginsDirectory = path.join(input.profileDirectory, "config", "plugins");
const userPluginsDirectory = path.join(input.userHome, ".gemini", "config", "plugins");
// The profile linker carries a user's enabled override for a plugin that ships disabled.
const plugins = new Map(
[...(yield* readAntigravityUserPlugins(input.userHome))].map(([name, plugin]) => [
name,
{ directory: plugin.directory, disabledByDefault: false },
]),
);
const names = yield* readIfPresent(fileSystem.readDirectory(pluginsDirectory), pluginsDirectory);
for (const name of names ?? []) {
const pluginDirectory = path.join(pluginsDirectory, name);
const target = yield* fileSystem.readLink(pluginDirectory).pipe(
Effect.map((value) => path.resolve(pluginsDirectory, value)),
Effect.orElseSucceed(() => undefined),
);
// Profile preparation replaces its links into the user's plugins, so those come from above.
if (target !== undefined && path.dirname(target) === userPluginsDirectory) continue;
const info = yield* readIfPresent(fileSystem.stat(pluginDirectory), pluginDirectory);
if (info?.type !== "Directory") continue;
// Profile folders count without a manifest, as they did before user plugins were linked.
const manifest = yield* readAntigravityPluginManifest(pluginDirectory);
plugins.set(name, {
directory: pluginDirectory,
disabledByDefault: manifest?.disabled === true,
});
}
if (plugins.size === 0) return [];
const preferences = yield* readAntigravityPluginPreferences(
path.join(input.profileDirectory, "config", "config.json"),
);
return [...plugins]
.filter(([name, plugin]) =>
isAntigravityPluginEnabled(plugin.disabledByDefault, preferences.get(name)),
)
.sort(([left], [right]) => (left < right ? -1 : left > right ? 1 : 0))
.map(([, plugin]) => plugin.directory);
});

function parseSkillFrontmatter(contents: string, fileName: string) {
const start = contents.indexOf("---");
if (start === -1) return undefined;
Expand Down Expand Up @@ -478,37 +617,8 @@ export const discoverAntigravitySkills = Effect.fn("discoverAntigravitySkills")(
);
}

const pluginsDirectory = path.join(input.profileDirectory, "config", "plugins");
const plugins = yield* readIfPresent(
fileSystem.readDirectory(pluginsDirectory),
pluginsDirectory,
);
if (plugins !== undefined && plugins.length > 0) {
const configPath = path.join(input.profileDirectory, "config", "config.json");
const configInfo = yield* readIfPresent(fileSystem.stat(configPath), configPath);
if (configInfo?.type === "File" && configInfo.size > BigInt(MAX_SKILL_BYTES)) {
return yield* new AntigravitySkillsProbeError({
reason: "scan-budget-exhausted",
path: configPath,
});
}
const config =
configInfo?.type === "File"
? yield* readIfPresent(fileSystem.readFileString(configPath), configPath)
: undefined;
const preferences = config === undefined ? undefined : decodePluginPreferences(config);
const disabled = new Set(
Object.entries(
(preferences?._tag === "Some" ? preferences.value.plugins : undefined) ?? {},
).flatMap(([name, plugin]) => (plugin.enabled === false ? [name] : [])),
);
for (const plugin of plugins.toSorted()) {
if (disabled.has(plugin)) continue;
const pluginDirectory = path.join(pluginsDirectory, plugin);
const info = yield* readIfPresent(fileSystem.stat(pluginDirectory), pluginDirectory);
if (info?.type !== "Directory") continue;
yield* scanDirectory(path.join(pluginDirectory, "skills"), "user", true);
}
for (const pluginDirectory of yield* readAntigravityPlugins(input)) {
yield* scanDirectory(path.join(pluginDirectory, "skills"), "user", true);
}
return [...skillsByName.values()].sort((left, right) => left.name.localeCompare(right.name));
});
Loading
Loading