Repository navigation
fix(server): whole-word content searches no longer miss matching files #39285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+75
−4
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the mock-call assertions with a regression that fails on
main.Lines 293-294 check the query string and mode, not the search result. The mocked search returns the same result for any query, so these lines are the only check on the native pattern. The testing guide excludes mock-call mirrors and requires a failing test first for a logic bug. The real-workspace cases do not provide that failing test. Their substring matches are discarded by the JavaScript word check on
main, so they pass there too.Add a real-workspace case that fails on
main:needleSuffixlines before a validneedleline in one file.On
main, grep returns at most 100 matches for a file. The cursor then moves to the next file, so the valid line is never returned. The native word-boundary pattern excludes the suffix lines, so the valid line is returned on this branch.Adding lines to the shared
words.tsfixture shifts the line numbers in the existing table expectations. Update those expectations with the new fixture.