Skip to content

fix(server): keep per-model Antigravity thinking levels after restart - #39398

Open
tensorcopy wants to merge 4 commits into
pingdotgg:mainfrom
tensorcopy:fix-antigravity-unobserved-thinking-levels
Open

tensorcopy wants to merge 4 commits into
pingdotgg:mainfrom
tensorcopy:fix-antigravity-unobserved-thinking-levels

Conversation

@tensorcopy

@tensorcopy tensorcopy commented Nov 19, 2026 •

Copy link
Copy Markdown

Problem

After a restart, an Antigravity model could lose its own thinking levels and show the currently selected model's levels instead. For example, low/medium/high/xhigh became low/medium/high; each model should retain the levels it last reported.

Change

Stop giving unobserved models the selected model's thinking descriptor. They now report no descriptor until observed, so the registry merge retains their previously reported capabilities. Selected and observed models still use their own descriptors, including an explicit absence of thinking options.

Scope

This is a small fix for an obvious catalog bug, so no separate issue is needed. It changes only Antigravity's model catalog construction and its regression tests.

Verification

  • Added a regression that publishes deep with low/medium/high/xhigh, then merges a restarted provider snapshot that has observed only fast with low/medium/high. On main, deep incorrectly becomes low/medium/high; with this change, it keeps xhigh.
  • Updated the catalog test to require no descriptor for an unobserved model.
  • Ran the following in apps/server; six files with 211 tests passed:
vp test run src/provider/AntigravityProvider.test.ts src/provider/Drivers/AntigravityDriver.test.ts src/provider/ProviderRegistry.test.ts src/provider/providerStatusCache.test.ts src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts src/provider/acp/AntigravityAcpSupport.test.ts
  • packages/provider-acp sessionConfig.test.ts: six tests passed.
  • effect-tsgo tsrs --noEmit, vp lint, and vp fmt --check are clean for the changed files.

I did not run the full repository suite or a live Antigravity session.

Claude Opus 5.5 in T3 Code.

Antigravity reports thinking levels only for the selected model. A model
the server had not observed yet was given the selected model's levels
(without a current value). Because that fallback was non-empty, the
registry merge replaced the levels the model had reported earlier, so a
model with more levels (for example xhigh) lost them after a restart.

An unobserved model now reports no thinking descriptor, which lets the
registry keep the levels it last reported.
@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 19, 2026
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Antigravity provider now derives thinking-level capabilities from each model’s observed configuration. Tests cover unobserved models and preservation of distinct model choices when catalogs merge after restart.

Changes: Antigravity thinking capabilities

Layer / File(s) Summary
Per-model capabilities and restart coverage
apps/server/src/provider/AntigravityProvider.ts, apps/server/src/provider/AntigravityProvider.test.ts
Each model reports capabilities from its own observed thinking configuration. Tests verify that unobserved models have no thinking descriptor and that merging catalogs after restart preserves each model’s reported choices.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: bugfix

Suggested reviewers: juliusmarminge, t3dotgg, macroscopeapp

Merge Risk: Minimal · up to cbc43

Antigravity models no longer inherit another model's thinking options, and a model keeps its previously reported options after a restart. The change is small, covered by targeted tests, and has no identified merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Antigravity per-model thinking levels are kept after restart. It uses the conventional commit form and matches the objective of stopping unobserved models from inherit…
Description check Passed The description follows the template. It has Problem, Change, Scope, and Verification sections, and each is filled in with specific content. The problem is stated with an example. The change explains …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: Antigravity per-model thinking levels are kept after restart. It uses the conventional commit form and matches the objective of stopping unobserved models from inheriting the selected model's thinking descriptor.

Full details: Description check

Explanation

The description follows the template. It has Problem, Change, Scope, and Verification sections, and each is filled in with specific content. The problem is stated with an example. The change explains why the registry merge now retains capabilities. Scope explains why no issue is linked, which the template allows for a small obvious fix. Verification gives focused test commands, the regression test, and results, and it states what was not run. The template asks for the model and harness used, and the author gives 'Claude Opus 5.5 in T3 Code', so that item is covered. The template's required issue link is replaced by the author's justification, which the template permits.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e61c256 and cbc438a.

Files selected for processing: 1

  • apps/server/src/provider/AntigravityProvider.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge juliusmarminge added takeover:needs-julius Takeover done; route gate says Julius decides and removed takeover:in-progress A takeover lead is working on this PR labels Nov 19, 2026
@tensorcopy
tensorcopy force-pushed the fix-antigravity-unobserved-thinking-levels branch from 81d67b9 to e61c256 Compare November 22, 2026 07:06
@rune-gh

rune-gh commented Nov 22, 2026

Copy link
Copy Markdown
Contributor

Hit this exact issue on live agy acp 1.5.14 (Windows):

  • After a T3 Code restart, running a session on gemini-4-neon (thought_level: low, high, xhigh) caused every unobserved Antigravity model in the picker to inherit Low / High / Extra—including claude-opus-5.5 (hiding Medium and offering Extra), claude-opus-4.6, and gpt-oss-120b-medium.
  • Direct JSON-RPC verification against agy acp 1.5.14 confirms session/set_config_option (configId: "model", value: "claude-opus-5.5") returns thought_level options low (Low), medium (Medium), and high (High), and sending thought_level: "xhigh" to claude-opus-5.5 fails with -32602:
    Thinking level "xhigh" is not offered for model "Claude Opus 5.5"
    
  • Likewise, claude-opus-4.6 / claude-sonnet-4.6 report only low / max, gemini-4-argon and gemini-3.1/3.5-flash-lite report low / high, and gpt-oss-120b-medium reports no thought_level option at all.

Dropping the currentThinking fallback for unobserved models here directly fixes the cross-model capability overwrite across restarts. +1!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). takeover:needs-julius Takeover done; route gate says Julius decides vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants