Repository navigation
fix(web): Option + a letter records the letter, not the macOS glyph #39967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+54
−0
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3b44687
test(web): Option + a letter records the letter, not the macOS glyph
juliusmarminge 56b5bcb
fix(web): Option + a letter records the letter, not the macOS glyph
juliusmarminge 599f098
fix(web): only map the US Option glyph back to its letter
juliusmarminge 151216a
Merge branch 'main' into factory/issue-38513
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restrict the glyph conversion to macOS recording.
German Windows AltGr+M produces
µatKeyM. Microsoft documents this exact character and position. (learn.microsoft.com)For
key="µ",code="KeyM", andaltKey=true, this branch returnsminstead of the previousµ. Both recorder paths receive the changed token, regardless of platform. The AltGraph guard inmatchesKeybindingShortcutdoes not protect recording.Gate this conversion on the recording platform. Preserve
µon Windows and keep the intendedπ-to-pconversion on macOS. Extend the existing recording table with this collision case.