Repository navigation
fix(claude): an API-error turn shows its error once, not also as a reply #40037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
3
commits into
main
Choose a base branch
from
factory/issue-24171-a24669
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−8
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
8fdee88
test(claude): an API-error turn is not also shown as a reply
juliusmarminge c8fa1c4
fix(claude): an API-error turn shows its error once, not also as a reply
juliusmarminge fda3cf1
fix(claude): fail a flagged result even when its terminal reason is n…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep a failed-result refusal visible after the synthetic frame is suppressed.
The new check at line 12053 removes the synthetic
API Errorreply before the result is evaluated. For a result withsubtype: "success"andis_error: true, the code can still end in this state:resultTextisnull(lines 12125-12130).terminalStatusFromResultreturns"completed"because nofailureHintand no failureterminal_reasonexist (lines 4723-4730).providerFailureFromResultbuilds a failure, but theturn.terminalevent setsfailure: nullfor a"completed"status (lines 9777-9778).The user then sees an empty completed turn and no refusal. The turn must still settle as failed when the result reports
is_error: true, even whenterminal_reasonis absent or does not map to a failure. Choose the fix so that this result keeps the refusal text as the failure message. The added test usesterminal_reason: "api_error", so it does not cover this path.