Repository navigation
fix(server): idle Git polls no longer re-read local status when no ref moved #40093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+59
−1
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep external working-tree and index edits visible during idle polls.
The idle poll now skips the local read when the ref snapshot is unchanged.
readRefSnapshotcovers onlyshow-ref --head, symbolicHEAD, and.git/shallow. It does not include index or working-tree state. TheHEADwatcher filters toHEADevents only. Before this change, each poll re-read local status, which reflected file edits and staging from outside the app. After this change, an edit or stage made in an external terminal does not triggerlocalUpdatedon the poll. Subscribers can keep stale Changes totals until a ref moves or another local refresh runs.The PR objectives require that local changes keep arriving through the head watcher. The inspected watcher reacts only to
HEADevents, so it does not deliver working-tree or index changes. Restore a delivery path for these changes. The change must not re-read local status on every idle poll when refs are unchanged. Choose the mechanism, such as a watcher on the index and working tree or an explicit refresh trigger, and document it.