You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): project folders can be dragged into order in the Boring sidebar - #40164
In the Boring sidebar, project folders cannot be reordered. The redesign removed the old sidebar's project drag, so Manual order is frozen there. #33227 restores ordering through a list in Settings → Projects. This adds direct dragging in the sidebar.
Change
Folder headers drag like thread rows. The order saves through reorderProjects, and the first drag switches Project order to Manual. Moves stay inside the pinned, unpinned, or archived section, and a group moves with all its checkouts.
Verification
vp run check:changed passes.
The reorder scenario passes at a75956732f in 22.5s, including reload persistence, a drop outside the sidebar, and a release in a gap.
On base 13226b1c21, the same drag leaves the order unchanged.
The sidebar now supports dragging project folders to reorder them. Folder drops update project order and can switch the client’s project sort order to Manual. Motion and shift-guard tracking now include rows nested inside folders.
Folder drags use section-aware collision detection and release-point hit testing. Shared drag lifecycle handling also accounts for active folder drags.
Order update and validation apps/web/src/uiStateStore.ts, apps/web/src/uiStateStore.test.ts, apps/web/src/components/Sidebar.tsx, scripts/scenarios/sidebar-project-folders-reorder.e2e.ts, docs/user/thread-sidebar.md
Folder drops update project order and set the client setting to Manual when needed. Tests cover grouped project keys, reload persistence, and drops outside folder targets. Documentation describes folder reordering.
Nested row position tracking apps/web/src/components/Sidebar.motion.ts, apps/web/src/components/Sidebar.shiftGuard.ts, apps/web/src/components/Sidebar.shiftGuard.browser.test.ts
Motion and shift-guard tracking include rows inside folder groups. Browser tests check shifted-row behavior for top-level and nested rows.
sequenceDiagram
participant User
participant DndContext
participant Sidebar
participant uiStateStore
participant ClientSettings
User->>DndContext: Drag and release a project folder
DndContext->>Sidebar: Send drag lifecycle events
Sidebar->>Sidebar: Hit-test release point and select target folder
Sidebar->>uiStateStore: Call reorderProjects with source and target keys
Sidebar->>ClientSettings: Set project sort order to manual when needed
Loading
Suggested reviewers:juliusmarminge, t3dotgg
Merge Risk: Low · up to 7d149
Folder drag-and-drop reordering works with a pointer. Keyboard-only users cannot reorder folders, which is a bounded accessibility gap that can be handled as a follow-up. No other merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: project folders in the Boring sidebar can now be reordered by dragging. It follows the conventional commit format and matches the raw summary and PR objectives, which …
Description check
The description covers the problem, the change, and verification. It names the reorder behavior, the Manual order switch, the section constraint, and the checks run, with screenshots and a recording. …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: project folders in the Boring sidebar can now be reordered by dragging. It follows the conventional commit format and matches the raw summary and PR objectives, which describe folder drag-reordering with persistence.
Full details: Description check
Explanation
The description covers the problem, the change, and verification. It names the reorder behavior, the Manual order switch, the section constraint, and the checks run, with screenshots and a recording. It does not state a scope justification with a linked bug issue; it links #33227 and #27062 as related work, and the Scope section is absent. This is a minor gap, so the description is mostly complete.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
…ease
The folder header keeps its pointer cursor like the draggable thread rows,
and release() again ignores rows that are fading out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
90-90: Minor · Functional Correctness · Heavy lift
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Provide a keyboard reorder action.
The folder header receives only SidebarPointerSensor listeners. Keyboard activation toggles the folder, but cannot start a reorder. The drop handler also requires a pointer release point. Add a keyboard reorder action and commit its selected target without requiring pointer coordinates. (raw.githubusercontent.com)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:L100-499 changed lines (additions + deletions).takeover:needs-juliusTakeover done; route gate says Julius decidesvouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Boring sidebar, project folders cannot be reordered. The redesign removed the old sidebar's project drag, so Manual order is frozen there. #33227 restores ordering through a list in Settings → Projects. This adds direct dragging in the sidebar.
Change
Folder headers drag like thread rows. The order saves through
reorderProjects, and the first drag switches Project order to Manual. Moves stay inside the pinned, unpinned, or archived section, and a group moves with all its checkouts.Verification
vp run check:changedpasses.a75956732fin 22.5s, including reload persistence, a drop outside the sidebar, and a release in a gap.13226b1c21, the same drag leaves the order unchanged.Before, dragging, and after reload:
Recording, 23s
Related to #33227 and #27062. The Settings list and the sidebar drag share the same saved order.
Note
Written by
deepseek-4.1-flashon behalf of chise