Repository navigation
fix(desktop): preview tabs drop a destroyed webview's WebContents #40177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9d28e8e
56432b8
8abcfca
cc26e0d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,7 @@ vi.mock(import("~/components/preview/previewBridge"), async (original) => ({ | |
| closeTab: mocks.closeTab, | ||
| registerWebview: mocks.registerWebview, | ||
| getPreviewConfig: mocks.getPreviewConfig, | ||
| onStateChange: () => () => {}, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cover the renderer's recovery from a null The mock at line 46 never calls the Add a browser test that captures the callback passed to
|
||
| } as never, | ||
| })); | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.