Skip to content

fix(cli): update Windows launchers outside PATH - #40309

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
gero3:fix/windows-standalone-launcher-update
Nov 21, 2026
Merged

juliusmarminge merged 2 commits into
pingdotgg:mainfrom
gero3:fix/windows-standalone-launcher-update

Conversation

@gero3

@gero3 gero3 commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Problem

On Windows, you can run t3.cmd by full path even when its folder is outside PATH and T3CODE_INSTALL_BIN_DIR is unset. In that case, t3 update could install the new version and leave the launcher pointing at the old one.

Change

Use the installer’s saved launcher paths as a fallback. When a recorded t3.cmd points to the executable being updated, repoint it to the new version.

Scope

One small Windows CLI bug fix and one regression test.

Verification

  • Reproduced with the published Windows CLI in a temporary T3 home. An update from 0.1.10 to 0.1.11 exited with code 0. The newly installed executable reported 0.1.11, while the same launcher still reported 0.1.10 and its contents were unchanged.
  • The regression test failed on Windows before the fix and passed afterward, confirming that t3.cmd points to the new executable. vp run check:changed origin/main passed with 26 tests passed and one skipped. A separate uninstall test failed both before and after the fix.

GPT-6.2 Sol via Codex in T3 Code.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 69401fb and 43d7606.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

Windows shim lookup now checks recorded launcher paths from the pinned runtime versions directory, as well as install-bin and PATH candidates. A test verifies that a recorded launcher outside PATH is repointed while preserving its command-line arguments.

Changes: Windows launcher lookup

Layer / File(s) Summary
Find and repoint recorded Windows launchers
apps/server/src/cli/update.ts, apps/server/src/cli/update.test.ts
findWindowsShim accepts an optional versions directory and checks recorded absolute t3.cmd paths. The test verifies that a recorded launcher outside PATH is updated and %* is preserved.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: juliusmarminge, macroscopeapp

Merge Risk: Minimal · previous review 69401

This change fixes the Windows update case where a launcher outside PATH kept pointing at the old executable. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(cli): update Windows launchers outside PATH" matches the main change. The PR repoints a recorded Windows t3.cmd launcher outside PATH to the newly updated executable, and the summary sh…
Description check Passed The description follows the template's main sections. It has Problem, Change, Scope, and Verification. The Problem and Change sections clearly describe the bug and fix. Scope names one small Windows C…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(cli): update Windows launchers outside PATH" matches the main change. The PR repoints a recorded Windows t3.cmd launcher outside PATH to the newly updated executable, and the summary shows changes to findWindowsShim in update.ts and a regression test in update.test.ts. The title is concise and uses a conventional commit prefix.

Full details: Description check

Explanation

The description follows the template's main sections. It has Problem, Change, Scope, and Verification. The Problem and Change sections clearly describe the bug and fix. Scope names one small Windows CLI fix and one regression test, but it does not link an issue or explain why no issue is needed, which the template asks for. Verification gives concrete reproduction steps and results, and it names the test command. The description does not state which agent or model produced the work in the form the template asks, but it does name GPT-6.2 Sol via Codex. The description also does not mention a maintainer request. These gaps are minor, so the description is mostly complete.

Resolution

Optionally add a link to the bug report or a short reason why no issue is needed in the Scope section. Optionally state the model and harness in the template's format, and note any checks that were not run.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c1464d6 and 69401fb.

Files selected for processing: 2

  • apps/server/src/cli/update.test.ts
  • apps/server/src/cli/update.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 21, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Evidence

Run on Windows Server 2025, PowerShell, identical 1920x1080 desktop/theme and fresh synthetic installation state. Each source commit was built as nightly 5024 and placed beside official runtime dependencies. Install into a custom directory containing a space, start a fresh session with that directory outside PATH and T3CODE_INSTALL_BIN_DIR unset, then invoke the recorded launcher by full path to update from 5024 to 5038. Both updates exit 0. Base leaves the launcher running 5024; head makes the same launcher run 5038.

Before After
Base leaves launcher on 5024 Head repoints launcher to 5038
3d8a02371b 43d7606c00
Before recording After recording
Base output Head output

Driver, setup script, capture script, window script, reproduction details. Recordings sample the actual desktop; elapsed time is slightly compressed by capture overhead. Final stills were pixel-identical 500 ms apart. Evidence uploaded using the ghdrop skill.

@juliusmarminge juliusmarminge added takeover:ready Takeover done; auto-lands when gates pass and removed takeover:in-progress A takeover lead is working on this PR labels Nov 21, 2026
@juliusmarminge
juliusmarminge merged commit 6644126 into pingdotgg:main Nov 21, 2026
19 checks passed
@juliusmarminge juliusmarminge removed the takeover:ready Takeover done; auto-lands when gates pass label Nov 21, 2026
cl0ckwork added a commit to cl0ckwork/t3code that referenced this pull request Nov 21, 2026
Merges 213 upstream commits (through pingdotgg#40309).

Conflicts were in the thread-scoped review RPCs. Upstream's pingdotgg#40211 completion token and
pingdotgg#40216 reused merge base are now fields of the fork's threadId-based review requests.
Upstream's multi-repository projects (pingdotgg#35925) let the Diff panel and Changes row pick a
repository. The fork carries that as an optional repositoryCwd, which ReviewService accepts
only inside the thread workspace, project root, tracked folders, or task folder root.

Also aligns the Codex replay fixture with the adapter's real order: the thread name is set
before selected skills resolve (this fork test had failed since upstream pingdotgg#37442).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AIdoesmyjob pushed a commit to AIdoesmyjob/t3code that referenced this pull request Nov 21, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 6644126)
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 21, 2026
**v0.1.12-nightly.20261121.5051** · 38 changes from 9 contributors

- **Queued slash commands.** Send slash commands while an agent is working without having to resend them after the turn.
- **Full file names.** Hover over truncated names in the Files tree to see the full file or folder name.
- **Faster change reviews.** Changes and Diff panels load with less repeated work, especially in large repositories.
- **Faster Git actions.** Committing, pushing, and pulling spend less time scanning large working trees.
- **Floating device preview.** The floating device preview stays connected when you switch threads.
- **Faster worktree removal.** Deleting a thread and its worktree no longer waits for a redundant status refresh.

### Plus 24 more bug fixes and performance improvements.

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(mobile): Vietnamese letters stay bold in bold text on Android by @juliusmarminge in pingdotgg/t3code#40205
* fix(desktop): preview tabs drop a destroyed webview's WebContents by @juliusmarminge in pingdotgg/t3code#40177
* fix(acp): persist context usage reported after a turn ends by @juliusmarminge in pingdotgg/t3code#40220
* perf(server): complete Changes preview reuses its tracked-only pass by @juliusmarminge in pingdotgg/t3code#40211
* feat(server): add a TanStack Source forge and issue tracker behind T3CODE_TANSTACK_SOURCE by @juliusmarminge in pingdotgg/t3code#40207
* perf(server): remote status polls read HEAD, upstream and remotes once by @juliusmarminge in pingdotgg/t3code#40162
* fix(client-runtime): opening the Diff panel reads each file patch once by @juliusmarminge in pingdotgg/t3code#40217
* fix(web): floating device preview keeps its stream across thread switches by @juliusmarminge in pingdotgg/t3code#40240
* fix(web): show update progress at the default sidebar width by @shivamhwp in pingdotgg/t3code#40242
* fix(web): inline file and thread chips can be removed during dictation by @juliusmarminge in pingdotgg/t3code#40252
* fix(web): typing and pasting no longer write into the read-only composer during dictation by @juliusmarminge in pingdotgg/t3code#40253
* fix(server): per-file diff reads reuse the preview's merge base by @juliusmarminge in pingdotgg/t3code#40216
* fix(acp-registry): reinstall the current version when a cached build was removed upstream by @juliusmarminge in pingdotgg/t3code#40261
* fix(server): Claude's answer before a late-read steer stays visible by @juliusmarminge in pingdotgg/t3code#40265
* fix(web): RTF previews hide tracked deletions by @geezoria in pingdotgg/t3code#40264
* perf(server): an untracked file's Diff panel patch no longer copies the whole Git index by @juliusmarminge in pingdotgg/t3code#40268
* perf(server): status of a repository without a remote skips remote lookups by @juliusmarminge in pingdotgg/t3code#40277
* fix(forgejo): issue links on a self-hosted Forgejo hostname resolve by @turnercore in pingdotgg/t3code#40271
* fix(web): switching threads no longer restarts the Changes and git status reads by @juliusmarminge in pingdotgg/t3code#40215
* fix(web): clipped Files tree names show the full name on hover by @juliusmarminge in pingdotgg/t3code#40308
* fix(cli): update Windows launchers outside PATH by @gero3 in pingdotgg/t3code#40309
* fix(server): typed-message commits stage the worktree once by @shivamhwp in pingdotgg/t3code#40282
* perf(server): a tracked file's Diff panel patch skips the untracked-file listing by @juliusmarminge in pingdotgg/t3code#40304
* fix(mobile): mark the linked line in the native source viewer by @juliusmarminge in pingdotgg/t3code#40295
* fix(server): slash commands sent during a turn wait instead of steering by @shivamhwp in pingdotgg/t3code#40316
* perf(server): push and commit-and-push read the full git status once instead of three times by @juliusmarminge in pingdotgg/t3code#40305
* fix(server): ACP session/load replay no longer pins background work by @juliusmarminge in pingdotgg/t3code#40328
* fix(mobile): confirming a push to the default branch no longer opens the thread a second time by @arifali123 in pingdotgg/t3code#40311
* fix(opencode): Usage → Limits shows why OpenCode could not read usage by @juliusmarminge in pingdotgg/t3code#40340
* perf(server): deleting a thread's worktree refreshes git status once, not twice by @juliusmarminge in pingdotgg/t3code#40337
* fix(antigravity): accept null skill manifest lists by @Lucenx9 in pingdotgg/t3code#40287
* fix(mobile): text selection menu items follow the UI language by @panol in pingdotgg/t3code#40297
* perf(server): pull no longer scans the working tree twice by @juliusmarminge in pingdotgg/t3code#40338
* fix(server): Antigravity Orchestrator usage prices at the base Gemini 4 rate by @juliusmarminge in pingdotgg/t3code#40352
* fix(server): treat a branch rename as done when Git moved the ref but kept the config locked by @juliusmarminge in pingdotgg/t3code#40361

## New Contributors
* @turnercore made their first contribution in pingdotgg/t3code#40271
* @gero3 made their first contribution in pingdotgg/t3code#40309

**Full Changelog**: pingdotgg/t3code@v0.1.12-nightly.20261121.5038...v0.1.12-nightly.20261121.5051

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.12-nightly.20261121.5051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants