You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(client-runtime): typing a bare Windows drive lists its folders - #40682
On a Windows host, typing a drive as D: in the folder picker shows an empty list with no message. D:\ works. On Android there is no native picker to fall back on, so an empty list reads as "other drives are not supported".
Reproduce: phone connected to a Windows environment, New thread → Add project → Local folder, replace ~/ with D:.
The server is fine: filesystem.browse with D: returns the drive's folders (55 on my machine). getFilesystemBrowsePath("D:", "Win32") returns filterQuery: "D:", so the client filters that listing by a name no folder can have.
Change
getFilesystemBrowsePath treats a bare drive as its root: directoryPath: "D:\\", empty filter. Mobile already navigates from directoryPath, so it needs nothing else.
Two web callers appended the picked folder to the raw query. With the list no longer empty, that would produce D:work\, so the command palette (row and Tab completion) and Settings → Projects → Add folder now append to directoryPath. For every other query the two are the same directory.
Scope
Small fix for an obvious bug, so no issue. It only fixes a path the picker already accepts. It adds no drive list; that is #33421, which does not touch this function. #29375 changes how a bare C: is submitted, in a different file; this changes only what is listed.
Verification
Found while adding a project on a second drive from my Android phone.
Test first: added a D: case to the existing derives the browse target and navigation state test. It failed on main with directoryPath: "D:", filterQuery: "D:", and passes with the fix.
Android, real Windows 11 host: Android 17 emulator, nightly server 0.1.12-nightly.20261122.5071 on Windows. I ran the same native build (2.3.0, 813) with the JS bundle from main and then from this branch. T: is a subst drive with sample folders.
main: T: lists nothing.
This branch: T: lists archive and work. Tapping work goes to T:\work\, tapping website and Add project created the project, stored as T:\work\website.
vp run check:changed passed on Windows: format, lint, knip, typecheck of 7 packages, 73 tests, React Compiler.
Not checked: iOS, and the two web callers in a browser (covered by typecheck and existing tests only). The APK was repacked with a local key so its arm64 libraries load on an x86_64 emulator, and with OTA updates off; it was not a Play build.
Reviewing files that changed from the base of the PR and between 2cbba45 and 331b8d4.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
Bare Windows drive queries now resolve to the drive root instead of using the drive prefix as a filter. Browse actions append selected and completed names to the parsed directory path.
Changes: Windows Drive Browse Path
Layer / File(s)
Summary
Normalize bare drive queries packages/client-runtime/src/state/filesystem.ts, packages/client-runtime/src/state/filesystem.test.ts
getFilesystemBrowsePath adds a backslash to a bare Windows drive query before deriving its directory and filter paths. A test checks the drive root, empty filter, and browse-up state.
Build browse paths from parsed directories apps/web/src/components/CommandPalette.tsx, apps/web/src/components/settings/ProjectRepositoriesSettings.tsx
Browse navigation, Tab completion, and folder selection append names to browsePath.directoryPath.
Typing a bare Windows drive now lists that drive's folders, and selecting or adding folders builds correct paths. No actionable merge risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: a bare Windows drive such as "D:" now lists its folders instead of an empty list. The raw summary and objectives confirm the change in getFilesystemBrowsePath (treatin…
Description check
The description follows the template sections (Problem, Change, Scope, Verification). It explains the bug, the drive-root fix, and why the two web callers also change. It gives a clear scope justifica…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: a bare Windows drive such as "D:" now lists its folders instead of an empty list. The raw summary and objectives confirm the change in getFilesystemBrowsePath (treating a bare drive as its root with an empty filter). The title is specific and follows the conventional commit format. It omits the web caller changes, which is acceptable because they are secondary.
Full details: Description check
Explanation
The description follows the template sections (Problem, Change, Scope, Verification). It explains the bug, the drive-root fix, and why the two web callers also change. It gives a clear scope justification for a small fix without an issue, plus a test-first result and a detailed Android check with a real Windows host. Remaining gaps are minor: the template asks for a linked issue or maintainer request, and the description gives a reason for omitting one. Unchecked areas (iOS, browser testing of web callers) are stated. The template's note about the agent model line is present.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Evidence: Windows Server 2025, headless Chromium, dark theme, 1440×1000, fresh isolated data. Ctrl+K → Add project → Local folder → enter C:\ → replace with C:. Base hides all folders; head lists them. On head, clicking work and Tab-completing highlighted work both navigate to C:\work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 changed lines (additions + deletions).vouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a Windows host, typing a drive as
D:in the folder picker shows an empty list with no message.D:\works. On Android there is no native picker to fall back on, so an empty list reads as "other drives are not supported".Reproduce: phone connected to a Windows environment, New thread → Add project → Local folder, replace
~/withD:.The server is fine:
filesystem.browsewithD:returns the drive's folders (55 on my machine).getFilesystemBrowsePath("D:", "Win32")returnsfilterQuery: "D:", so the client filters that listing by a name no folder can have.Change
getFilesystemBrowsePathtreats a bare drive as its root:directoryPath: "D:\\", empty filter. Mobile already navigates fromdirectoryPath, so it needs nothing else.Two web callers appended the picked folder to the raw query. With the list no longer empty, that would produce
D:work\, so the command palette (row and Tab completion) and Settings → Projects → Add folder now append todirectoryPath. For every other query the two are the same directory.Scope
Small fix for an obvious bug, so no issue. It only fixes a path the picker already accepts. It adds no drive list; that is #33421, which does not touch this function. #29375 changes how a bare
C:is submitted, in a different file; this changes only what is listed.Verification
Found while adding a project on a second drive from my Android phone.
D:case to the existingderives the browse target and navigation statetest. It failed onmainwithdirectoryPath: "D:",filterQuery: "D:", and passes with the fix.0.1.12-nightly.20261122.5071on Windows. I ran the same native build (2.3.0, 813) with the JS bundle frommainand then from this branch.T:is asubstdrive with sample folders.main:T:lists nothing.T:listsarchiveandwork. Tappingworkgoes toT:\work\, tappingwebsiteand Add project created the project, stored asT:\work\website.vp run check:changedpassed on Windows: format, lint, knip, typecheck of 7 packages, 73 tests, React Compiler.Not checked: iOS, and the two web callers in a browser (covered by typecheck and existing tests only). The APK was repacked with a local key so its arm64 libraries load on an x86_64 emulator, and with OTA updates off; it was not a Play build.
T:T:workModel: Claude Opus 5.5, Claude Code in T3 Code.
🤖 Generated with Claude Code