Skip to content

fix(web): preserve reply-only edits when a queued message leaves the queue - #40763

Merged
juliusmarminge merged 5 commits into
pingdotgg:mainfrom
iiijiashu:fix/web-queued-edit-reply-only
Nov 22, 2026
Merged

juliusmarminge merged 5 commits into
pingdotgg:mainfrom
iiijiashu:fix/web-queued-edit-reply-only

Conversation

@iiijiashu

Copy link
Copy Markdown
Contributor

Problem

When a user edits a queued message by only adding, changing, or removing its reply citation (without changing the prompt text or attachments) and the run leaves the queue before saving, recoverQueuedMessageEdit treated the edit as "clean", silently dropping the unsaved reply change instead of preserving it in an idle composer draft or reporting discard.

Fix

Pass the parsed originalReplyTo (reply ?? null) from useQueuedRunEdit.ts into recoverQueuedMessageEdit, and compare draft?.replyTo ?? null with input.originalReplyTo using Equal.equals from effect/Equal in queuedMessageEdit.ts so structural changes are recovered while unchanged reconstructed records remain "clean".

Verification

  • Failing before fix (RED):
    • Command: .\node_modules\.bin\vp.cmd test run apps/web/src/components/chat/queuedMessageEdit.test.ts apps/web/src/components/chat/useQueuedRunEdit.browser.test.tsx
    • Result: exited 1 (Test Files 2 failed (2), Tests 5 failed | 24 passed (29)), with reply add/change/remove cases returning 'clean' and the Chromium hook test losing the draft on thread navigation.
  • Passing after fix (GREEN):
    • Same command after fix: exited 0 (Test Files 2 passed (2), Tests 29 passed (29)).
  • Changed-file checks:
    • .\node_modules\.bin\vp.cmd run check:changed: exited 0 (format, lint, knip checks, affected package typechecks, and focused tests passed; git diff HEAD^ HEAD --check exited 0).
    • Note on Windows React Compiler check: check:changed's path-based -t filter skipped all cases on Windows path separators, so React Compiler coverage for the two modified source files was run explicitly with .\node_modules\.bin\vp.cmd test run apps/web/src/reactCompilerCoverage.test.ts -t '[qQ]ueued[A-Za-z]*Edit[.]ts$' --reporter=verbose (2 passed | 1461 skipped, exited 0).
  • Not checked:
    • Did not launch a separate end-to-end dual-client Web + server session outside the useQueuedRunEdit.browser.test.tsx Chromium harness.

Model/harness: OpenAI gpt-6.2-astra (reasoningEffort: xhigh) in Codex via T3 Code; reviewed by Orchestrator (Neon) and @iiijiashu.

Copilot AI balanced review requested due to automatic review settings November 22, 2026 09:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 22, 2026
@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Queued edit recovery now compares the draft reply target with its original context. The queue-exit path supplies that context. Tests cover recovery outcomes for added, removed, and unchanged replies.

Changes: Queued Edit Recovery

Layer / File(s) Summary
Compare reply context during recovery
apps/web/src/components/chat/queuedMessageEdit.ts, apps/web/src/components/chat/useQueuedRunEdit.ts, apps/web/src/components/chat/queuedMessageEdit.test.ts
recoverQueuedMessageEdit accepts the original reply context and treats a changed draft reply target as an edit change. onRunLeftQueue passes the edited reply context, or null when none exists. Tests cover added, removed, and unchanged replies, plus existing attachment and draft recovery cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

  • Issue 15611 describes queued messages dispatching while an edit is open. This PR changes edit recovery when a message leaves the queue, but does not add the dispatch guard described in the issue.

Possibly related PRs

  • pingdotgg/t3code#24972: Both PRs change queued-edit recovery decisions, including whether an edit is kept, discarded, or treated as clean.

Suggested labels: bugfix

Suggested reviewers: stienswout, saphid

Merge Risk: Minimal · up to 285b7

This change keeps reply-citation edits to a queued message when the run leaves the queue before the user saves. Edits are now kept in an idle draft instead of being silently dropped. The change is small and well covered by tests, and no merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the fix and its scope: reply-only edits to a queued message are preserved when the message leaves the queue. The raw summary shows the reply comparison in recoverQueuedMessageEdit and …
Description check Passed The description follows the template's main sections: Problem, Change, Scope, and Verification. The Problem and Change sections state the bug and the fix with file references. The Verification section…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the fix and its scope: reply-only edits to a queued message are preserved when the message leaves the queue. The raw summary shows the reply comparison in recoverQueuedMessageEdit and the call-site change in useQueuedRunEdit.ts, so the title matches the main change. It follows a conventional commit format in plain language.

Full details: Description check

Explanation

The description follows the template's main sections: Problem, Change, Scope, and Verification. The Problem and Change sections state the bug and the fix with file references. The Verification section lists the failing-before and passing-after test runs, the changed-file checks, and what was not checked. The Scope section does not link an issue or state why none is needed. It also does not say whether a maintainer requested the PR. The template asks for both, so this is the main gap.

Resolution

Optionally add a link to the issue that shows the bug, or a sentence explaining why no issue is needed for this small fix. Also state whether a maintainer requested the PR. The description is otherwise complete enough to pass.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4e7a1f7 and 285b7a9.

Files selected for processing: 1

  • apps/web/src/components/chat/queuedMessageEdit.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 22, 2026
juliusmarminge and others added 4 commits November 22, 2026 09:31
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restore the browser test for text-change recovery and drop the table row
that repeated existing text-change behaviour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge

Copy link
Copy Markdown
Member

Evidence

Real web app, Chromium 1280×800, light theme, fresh synthetic data and approval replay on both commits. Approve the first turn; start another approval-blocked turn; queue Queued follow-up; edit it, attach a reply and save; edit again and remove only the reply without saving; approve the blocked turn so the queued run starts.

Before After
Before: reply-only edit silently cleared After: text recovered without citation and recovery toast shown
62a7108904 285b7a9ec5
Before recording After recording

Scenario driver. scenarios:prove exited 0: base failed because the composer was empty; head passed text recovery, notification, and absent-reply checks.

Not shown:

  • The scenario covers removing a reply citation when the queued run starts. Adding or changing only a reply, unchanged-reply cleanliness, departure caused by a second client, and discard when recovery is unavailable were not exercised.

@juliusmarminge juliusmarminge added takeover:ready Takeover done; auto-lands when gates pass and removed takeover:in-progress A takeover lead is working on this PR labels Nov 22, 2026
@juliusmarminge
juliusmarminge merged commit d834a4e into pingdotgg:main Nov 22, 2026
56 checks passed
@juliusmarminge juliusmarminge removed the takeover:ready Takeover done; auto-lands when gates pass label Nov 22, 2026
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 22, 2026
**v0.1.12-nightly.20261122.5098** · 59 changes from 25 contributors

- **Issue activity links.** Open referenced issues and pull requests directly from an issue’s Activity list.
- **Linked project folders.** Browse linked folders when adding or opening a project.
- **TanStack Source pull requests.** Open TanStack Source pull requests from any client, including pull requests in private repositories.
- **Antigravity permissions.** Auto and Auto-accept edits no longer prompt for T3 Code’s own tools.
- **Project action drafts.** Clicking outside the action editor no longer discards your unsaved changes.
- **Script-only threads.** Return to a new thread’s script output and controls from the sidebar, even without sending a message.

### Plus 50 more bug fixes and performance improvements.

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(antigravity): pre-approve T3 MCP tools in Auto and Auto-accept edits by @charlesbine in pingdotgg/t3code#39822
* fix(server): Antigravity keeps Auto in the mode picker after a restart by @juliusmarminge in pingdotgg/t3code#40154
* fix(client-runtime): a new thread's first message and a queued send-now or steer survive a dropped socket by @Tgoh in pingdotgg/t3code#40703
* fix(server): long webhook prompts in the delivery log no longer end in a broken character by @tiliakoos in pingdotgg/t3code#40726
* fix(server): a released ACP session no longer leaves its run stuck running by @juliusmarminge in pingdotgg/t3code#40734
* feat(web): sidebar thread rows show the environment instead of the branch by @juliusmarminge in pingdotgg/t3code#40736
* fix: a failed checkpoint capture keeps Edit from here for conversation rewind by @juliusmarminge in pingdotgg/t3code#40745
* docs(claude): mobile shows the compact chip too by @juliusmarminge in pingdotgg/t3code#40755
* fix(server): TanStack Source pull requests open from every client, and private ones work end to end by @juliusmarminge in pingdotgg/t3code#40741
* fix: include delegated threads in CLI listing by @dajiaohuang in pingdotgg/t3code#40738
* fix(pi): turn token usage counts cached tokens as input and stays per turn by @juliusmarminge in pingdotgg/t3code#40758
* fix(mobile): usage account detail keeps even pace current while open by @juliusmarminge in pingdotgg/t3code#40759
* fix(server): Resume sends pending context to providers without native resume by @juliusmarminge in pingdotgg/t3code#40764
* fix(server): a failed or cancelled clone no longer blocks re-cloning its destination by @amanthanvi in pingdotgg/t3code#40739
* fix: retain pull request metadata in thread show by @dajiaohuang in pingdotgg/t3code#40744
* fix(web): show Queue for running sessions that cannot steer by @iiijiashu in pingdotgg/t3code#40767
* fix(web): a click outside the project action editor no longer discards the draft by @AymanKhan9 in pingdotgg/t3code#40776
* fix(server): t3 pair skips Windows VirtualBox and VMware host-only adapters by @juliusmarminge in pingdotgg/t3code#33441
* fix(server): Word text boxes keep their paragraph breaks for agents by @KyrosHendrix in pingdotgg/t3code#40782
* fix(web): RTF previews respect hidden character formatting by @geezoria in pingdotgg/t3code#40783
* fix(mobile): the iOS composer keeps its keyboard and caret after dictation by @arun279 in pingdotgg/t3code#33916
* fix(shared): find file links whose labels contain brackets by @Abhiram-745 in pingdotgg/t3code#40781
* fix(web): restore effort picker keyboard typeahead by @juliusmarminge in pingdotgg/t3code#40798
* fix(server): migration 75 no longer fails on an unreadable subagent payload by @juliusmarminge in pingdotgg/t3code#30783
* fix(issues): an Activity cross-reference opens the issue or pull request it came from by @juliusmarminge in pingdotgg/t3code#40768
* fix(server): tell a stopped parent which delegated tasks its Stop interrupted by @juliusmarminge in pingdotgg/t3code#34499
* fix(server): worktree thread lookups match any spelling of the path by @juliusmarminge in pingdotgg/t3code#36802
* fix(mobile): prevent clipped percentages in usage limit cards by @peterxiemin in pingdotgg/t3code#40778
* test(web): browser tests no longer fail when a stale optimizer cache reloads them mid-run by @Brechard in pingdotgg/t3code#31999
* fix(github): superseded runs' cancelled checks no longer block PR watches by @juliusmarminge in pingdotgg/t3code#30434
* fix(web): keybindings using '+' show a plus keycap instead of empty pills by @AymanKhan9 in pingdotgg/t3code#40808
* fix(web): lineage show-more no longer clips the last row or drops focus by @justsrc in pingdotgg/t3code#31295
* fix(mobile): pulling to Load earlier activity no longer snaps the feed back to the end by @juliusmarminge in pingdotgg/t3code#31907
* perf(dev): incremental, cached server typecheck like web and desktop (body edit 10.3 s → 5.4 s) by @Pyseph in pingdotgg/t3code#30879
* fix(contracts): delegate_task options example says ids differ by provider by @juliusmarminge in pingdotgg/t3code#40806
* fix(web): preserve reply-only edits when a queued message leaves the queue by @iiijiashu in pingdotgg/t3code#40763
* fix(server): t3 start ignores a stale runtime record whose PID was reused by @juliusmarminge in pingdotgg/t3code#28256
* fix(server): runtime prune removes the runtime a committed update replaced and abandoned staging by @juliusmarminge in pingdotgg/t3code#40817
* fix(server): preserve cancellations during checkpoint capture by @voltcrash in pingdotgg/t3code#31349
* fix(web): a failed main chunk load reloads once instead of showing the boot error by @juliusmarminge in pingdotgg/t3code#26451
* fix(server): slash commands reach the provider verbatim when context is pending by @juliusmarminge in pingdotgg/t3code#30261
* fix(opencode): a command that never calls the model no longer leaves the turn running by @juliusmarminge in pingdotgg/t3code#27378
* fix(mobile): model search finds legacy models by @juliusmarminge in pingdotgg/t3code#27587
* fix(acp): follow a mode the agent leaves on its own so picking it again applies by @juliusmarminge in pingdotgg/t3code#40818
* fix(web): settling a thread no longer jolts the sidebar list by @flamboh in pingdotgg/t3code#26661
* fix(server): Word files whose main part is not word/document.xml reach the agent by @Marve10s in pingdotgg/t3code#40777
* fix(server): wake the agent when Claude exits while it awaits background work by @juliusmarminge in pingdotgg/t3code#30214
* fix(web): Usage Limits no longer shows a stale scrollbar by @inanimran in pingdotgg/t3code#40816
* fix(web): closing the last open pull request clears it from the list by @MyDigitalLife in pingdotgg/t3code#29438
* fix(mobile): account badge on the provider icon is readable without an accent color by @juliusmarminge in pingdotgg/t3code#40837
* fix(server): Claude turns no longer stall on empty or partial stream usage frames by @lln556 in pingdotgg/t3code#40804
* fix(server): filesystem browse lists symlinks pointing to directories by @lln556 in pingdotgg/t3code#40830
* fix(client-runtime): a resumed thread renders its catch-up once instead of stepping through stale states by @ahalekelly in pingdotgg/t3code#27401
* fix(web): clicking the Tab hint inserts short prompt suggestions again by @floklein in pingdotgg/t3code#40841
* fix(web): keep script-only drafts reachable in the sidebar by @juliusmarminge in pingdotgg/t3code#25272
* fix(server): retire unresponsive shared Codex app-servers by @juliusmarminge in pingdotgg/t3code#25123
* fix(shared): Windows command discovery no longer blocks the event loop by @maria-rcks in pingdotgg/t3code#27391
* fix(client-runtime): stop sessions on incompatible server configuration by @juliusmarminge in pingdotgg/t3code#21667
* fix(web): browser page translation no longer crashes the app when a turn updates by @juliusmarminge in pingdotgg/t3code#40856

## New Contributors
* @amanthanvi made their first contribution in pingdotgg/t3code#40739
* @iiijiashu made their first contribution in pingdotgg/t3code#40767
* @KyrosHendrix made their first contribution in pingdotgg/t3code#40782
* @Abhiram-745 made their first contribution in pingdotgg/t3code#40781
* @peterxiemin made their first contribution in pingdotgg/t3code#40778
* @inanimran made their first contribution in pingdotgg/t3code#40816
* @MyDigitalLife made their first contribution in pingdotgg/t3code#29438
* @lln556 made their first contribution in pingdotgg/t3code#40804

**Full Changelog**: pingdotgg/t3code@v0.1.12-nightly.20261122.5085...v0.1.12-nightly.20261122.5098

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.12-nightly.20261122.5098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants