Repository navigation
fix(acp): follow a mode the agent leaves on its own so picking it again applies #40818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+350
−4
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ed40a5a
test(server): reproduce #27646 agent-initiated mode switch sticking a…
juliusmarminge 945cb7a
fix(server): reapply an ACP agent's selected mode after it switches m…
juliusmarminge 710a964
test(server): an unchanged ACP mode is not re-sent after the reapply
juliusmarminge 6c4c040
Merge remote-tracking branch 'origin/main' into fix/issue-27646
juliusmarminge 1d0e554
fix(acp): a mode-only update no longer hides the drift from the mode …
juliusmarminge acac83a
Merge remote-tracking branch 'origin/main' into fix/issue-27646
juliusmarminge 5689e51
test(server): cover the mode reapply with one v1 replay transcript
juliusmarminge fb53a55
Merge remote-tracking branch 'origin/main' into fix/issue-27646
juliusmarminge 866db49
revert(acp): stop forcing the selected mode back after the agent leav…
juliusmarminge 6bb0e0a
fix(acp): follow a mode the agent left itself so picking it again app…
juliusmarminge 25baf2f
fix(acp): report only the modes the agent changed, not the whole sele…
juliusmarminge 1d368f9
Merge remote-tracking branch 'origin/main' into fix/issue-27646
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restrict the mode config sync to the option that supplied the mode ID.
When a session response has no
modesfield and severalmodeselect options,parseSessionModeStatereads only the first one. The new sync then writes that first value into everymodeselect option whosecurrentValuediffers. A second option, such asreview-modewith valuesstrictandrelaxed, can receive acurrentValuethat its options do not contain.Update only the option that the parser read, and leave the other config options unchanged. Do not rewrite option values from an authoritative
config_option_updatepayload.