Repository navigation
Update check_restricted_query_access to pass active engine and environment - #1734
Merged
jasoncoffman merged 2 commits intoSep 15, 2026
Merged
Conversation
jasoncoffman
marked this pull request as ready for review
September 15, 2026 17:31
suryabhaskarkarri
approved these changes
Sep 15, 2026
kgopal492
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The existing
check_restricted_query_accessfunction only exposes SAFE_ENVIRONMENTS and SAFE_QUERY_ENGINES as knobs for controlling whether or not a query access should be restricted. This prevents more fine-grained control of when/why query access may be restricted.Solution
Add generic support for kwargs in
check_restricted_query_accessand allow function implementations to use environment and engine context when available to check if query access should be restricted for the given engine_id or environment_id.The enables engines/environments not in the SAFE_* list to be conditionally allowed via the
check_restricted_query_accessimplementationTest Plans
Unit tests added; verified manually