"YCbCr Matrix: None" guessing bug (seems doing full (pc) range instead of limited (tv) range)

[realfinder]

as said here #10 (comment)

I think this easy to fix :)

[seiya-git]

Can u test this build?
assrender_bin_win.zip

[seiya-git]

mpv for "ctest5HD vid.avi" set bt.601 for hd, but assrender use bt.709 for width > 1024 or height > 576 in this build, should we set bt.601 for any video size if matrix not set in frame prop?

[realfinder]

Can u test this build?
assrender_bin_win.zip

that fix it! thanks!

but still act weird without frame properties! propClearAll().assrender("Z:\ctest5\ctest5.ass"), the weird thing is that the video colors change which assrender should not do that (it should only have an effect on YCbCr subtitle output. The video should always be untouched.)

[realfinder]

mpv for "ctest5HD vid.avi" set bt.601 for hd, but assrender use bt.709 for width > 1024 or height > 576 in this build, should we set bt.601 for any video size if matrix not set in frame prop?

I think that should be the case of "'YCbCr Matrix' is missing from a script", not if "YCbCr Matrix: None" which is different case

[seiya-git]

when 'YCbCr Matrix' is missing from a script assrender set "color_mt = MATRIX_BT601;" for any video size

[realfinder]

when 'YCbCr Matrix' is missing from a script assrender set "color_mt = MATRIX_BT601;" for any video size

yes, that was done since #2 (for now the only one that still dont follow clsid2/mpc-hc#974 (comment))

also there are this #5

[seiya-git]

I see, I will look into it

[seiya-git]

a = AVISource("ctest5SD vid.avi").propSet("_Matrix", 1).assrender("ctest5.ass")
b = AVISource("ctest5SD vid.avi").propClearAll().assrender("ctest5.ass")
Overlay(a, b, mode="difference", pc_range=false)

and

a = AVISource("ctest5HD vid.avi").propSet("_Matrix", 5).assrender("ctest5.ass")
b = AVISource("ctest5HD vid.avi").propClearAll().assrender("ctest5.ass")
Overlay(a, b, mode="difference", pc_range=false)

Strange that there are no differences here.
I also compared MPV and AvsPmod: both show the same colors from the AVS script, regardless of whether ASSRender is used.

[realfinder]

Strange that there are no differences here.

yes this code wont trigger it, you should use avspmod and switch between the "ctest5SD vid.avi" and "ctest5HD vid.avi"

AVISource("Z:\ctest5\ctest5HD vid.avi").propSet("_Matrix", 1)
#~ AVISource("Z:\ctest5\ctest5SD vid.avi").propSet("_Matrix", 5)

propClearAll().assrender("Z:\ctest5\ctest5.ass")

[seiya-git]

It's not AssRender's fault, because AssRender doesn't change the frame colors; it only blends the subtitle-rendered frame with the target frame.

[realfinder]

It's not AssRender's fault, because AssRender doesn't change the frame colors; it only blends the subtitle-rendered frame with the target frame.

but it only happen with AssRender

[seiya-git]

Can u test this build?
assrender64.zip
also fixed error displaying if file not found...

[realfinder]

Can u test this build?
assrender64.zip

that work fine! thanks!

you can do a PR so pinterf can merge it and close this

[seiya-git]

@pinterf @realfinder
#50
Probably we can set this as 0.36.0 release?

[realfinder]

Probably we can set this as 0.36.0 release?

sure, it's been a long time since the last update (I think Libass and the other components have improved a lot since then), and the recent fixes are also worthwhile