GRAL-6005 replace pull_request_target with pull_request - #743
Merged
Conversation
dmitriyeff
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://pipedrive.atlassian.net/browse/GRAL-6005
Summary
Replaces the
pull_request_targettrigger withpull_requestin two GitHub Actions workflows, per a suggestion raised in#devops-public.on-commit.yml: was usingpull_request_targetwith norefoverride on checkout, so it always testedmasterinstead of the PR's actual changes. It doesn't use any secrets, so there's no reason for the elevated trigger. Switching topull_requestfixes both issues — it removes unneeded secret/write-token exposure and makes checkout default to the PR's merge commit.on-pd-bot-pr-opened.yml: was usingpull_request_target, gated ongithub.actor == 'pipedrive-bot'(same-repo bot PRs only).pull_requestworks identically for this case and removes the theoretical risk of fork PRs executing code if the actor check is ever bypassed.