Repository navigation
Backmerge 1.39.0 - #3323
Merged
Merged
Backmerge 1.39.0#3323
Conversation
* fix(boost): cap world boss and adventure boss reward boosts at 5x A BoostScheduleSheet row for WORLD_BOSS_BATTLE_REWARD, WORLD_BOSS_KILL_REWARD, WORLD_BOSS_RANK_REWARD, ADVENTURE_BOSS_FLOOR_REWARD or ADVENTURE_BOSS_FIRST_CLEAR_REWARD had no upper bound. A mistyped value (e.g. a block index pasted into the value cell) made ClaimRaidReward add several int.MaxValue circle counts to one inventory slot, overflowing it to a negative count. Each boosted amount is now capped at 5 times the drawn amount, ADD included, computed in 64 bits (WorldBossHelper.MaxWorldBossRewardBoostFactor, AdventureBossHelper.MaxAdventureBossRewardBoostFactor). Lower bounds are unchanged (world boss 0, adventure boss 1) and an amount of 0 is still never boosted. Also make SummonHelperTest.GetSummonRecipeIdsWithGradeGuarantee_AppliesBoost fail when the boost is dropped: assert the last 7 summons are all grade 4+ and that the unboosted run with the same seed is not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: document constants next to the boost reward caps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release/1.39.0의 릴리즈 커밋을 development 로 백머지합니다.🤖 Generated with Claude Code