Repository navigation
bundle xlr manifest - #13
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 35.88% 40.74% +4.85%
==========================================
Files 27 29 +2
Lines 1956 2145 +189
Branches 159 199 +40
==========================================
+ Hits 702 874 +172
- Misses 1252 1267 +15
- Partials 2 4 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 of 3 tasks
KetanReddy
approved these changes
Sep 24, 2026
spentacular
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds player xlr bundle — a new command that bundles several already-compiled packages' Assets/Views capabilities into one manifest, keyed by type name (e.g. input) instead of by source package. This lets a consumer look up "what package implements input" before installing anything — the per-package manifest xlr compile already produces can't answer that, since reading it requires having installed the package already.
Enhanced xlr compile with metadata for collision with same type. lets a topic tell colliding entries apart, mirroring the shape a @player-ui/partial-match-registry discriminator uses at runtime (e.g. { kind: "card" }).
Scope: Assets/Views only.
other player capabilities like DataTypes/Formatters/Validators/Expressions ship are excluded.
Collision behavior: when two sources produce the same type name, bundle keeps both entries rather than picking a winner — that choice belongs to whichever topic hits the collision, in its own config.
Config additions:
bundleSources: Array — packages/directories to collate; falls back from -s flags (flags win, matching this repo's documented config-vs-flag precedence).
bundleMetaData: Record<string, Record<string, unknown>> — keyed by the exact --source value.
Also included on this branch: the xlr compile package-identity work (config.xlr.platformPackages, Bazel env-var-driven react/ios/android stamping in packages.ts) that bundle depends on to produce a complete packages block per entry.
Companion Bazel-side change: a matching xlr_bundle macro has been added in rules_player (player-ui/rules_player#122 ) — Bazel builds supply sources as an explicit, ordered list of target labels rather than a config file.
Companion xlr interface change: player-ui/xlr#14
Test result:
Change Type (required)
Indicate the type of change your pull request is:
patchminormajor