Repository navigation
catch errors and shorten details - #1269
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused error-handling changes preserve successful responses, and static review identified no blocking issues.
No open issues 🎉
What changed in this PR
Adds error handling to template API resources so rendering failures return empty HTTP 500 responses instead of exposing exception details.
Changes:
- Catches rendering errors in both resources.
- Logs failure details server-side while preserving successful responses.
| File | Description |
|---|---|
| src/Api/Resources/TemplateResource.php | Handles and logs Twig rendering failures. |
| src/Api/Resources/OrderTemplateResource.php | Handles and logs order-template rendering failures. |
Review effort: Balanced
ksted
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All changes meet the following requirements
@plentymarkets/plentyshop