Repository navigation
Fix language files that break Spanish, Welsh and Uzbek locales - #380
Merged
Cannonb4ll merged 1 commit intoOct 5, 2026
Merged
Conversation
lang/es/validation.php started with leftover text and a Markdown fence before the opening PHP tag, so loading the es validation group printed "Aqui esta la traduccion al espanol: ```php" into the response. lang/cy/auth.php and lang/uz_Latn/auth.php contained unescaped apostrophes, causing a ParseError whenever an auth.* key was translated for a user with one of those locales selected on their profile. Add a test that requires every lang/*/*.php file and asserts it returns an array without producing output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three locale files break when Laravel loads them.
What users see:
<?phptag. Laravel requires the file to load the validation group, so that text is printed into the page output whenever a Spanish validation message is used.Dyma'r. The file doesn't parse, so anytrans('auth.*')call for a cy user or app throws a ParseError (for example the wrong password message on the password protection page).Yorug') and :24 (noto'g'ri) have the same problem.Changes:
Verification:
php -lon main: lang/cy/auth.php and lang/uz_Latn/auth.php fail with "syntax error". On this branch all 641 lang//.php files pass.Loading es/validation.php on main prints the 48 bytes of leftover text. On this branch it prints nothing and returns 78 keys.
The new test: 3 failures against the lang files from main (cy/auth, uz_Latn/auth, es/validation), 641 passed on this branch.
Full Pest suite locally: the same 107 tests fail on main and on this branch. My setup has no frontend build (no Vite manifest). No new failures.