Repository navigation
fix: apply data and layout changes made while the plot is initializing - #374
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlotlyComponentdrops[data]and[layout]changes made whilePlotly.newPlotis still pending, for example while plotly.js loads from a CDN.ngDoCheckconsumes the differ's diff but skipsupdatePlot()becauseplotlyInstanceis not set yet, so the chart keeps showing the initial input.This change records the skipped update and applies it once the plot is created.
Fixes #373
Changes
ngDoChecksets a pending flag when it detects a change beforeplotlyInstanceexists.createPlot()callsupdatePlot()after initialization when the flag is set.datawhilenewPlotis pending and expects one update after it resolves.Testing
ng test plotly --watch=false --browsers ChromeHeadless: the new spec fails without the fix (1 of 50 failed) and passes with it (50 of 50).npm run lint,npm test, andnpm run build:demopass.This targets
v20, the oldest affected maintained branch, as described inMAINTENANCE.md. The commit cherry-picks cleanly ontomaster.