Fix - Table question column type edge cases - #50
Conversation
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Stanislas <skita@teclib.com>
|
i'll send the patch to the customer for feedback |
| <select | ||
| class="form-select form-select-sm" | ||
| name="{{ input_base }}[{{ row_index }}][col_{{ col_index }}]" | ||
| data-af-needs-ajax-s2 |
There was a problem hiding this comment.
The <select data-af-needs-ajax-s2> is rendered with zero <option> tags. If window.setupAjaxDropdown is unavailable at init time (script load failure, timing edge case), the user sees a native empty dropdown with no options and no placeholder text. A single disabled placeholder option would make the graceful-degradation state usable.
| <select | ||
| class="form-select form-select-sm" | ||
| name="{{ input_base }}[__ROW__][col_{{ col_index }}]" | ||
| data-af-needs-ajax-s2 |
There was a problem hiding this comment.
The <select data-af-needs-ajax-s2> is rendered with zero <option> tags. If window.setupAjaxDropdown is unavailable at init time (script load failure, timing edge case), the user sees a native empty dropdown with no options and no placeholder text. A single disabled placeholder option would make the graceful-degradation state usable.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Two related fixes for the Table question type's column configuration:
getSubTypes()) other plugins would use for this, no plugin-specific code added.