fix(readme): state the outbound-request position precisely - #187
Merged
Merged
Conversation
readme.txt led with "The version on WordPress.org makes no outbound request at all" and then, two lines later, listed four things that do make one — papering over the contradiction with "Apart from that". CLAUDE.md's first non-negotiable calls that absolute "simply false" and flagged the public copy as an open task. What is actually true: the WordPress.org build never checks for its own updates, because the updater file is not in that zip. The four user-initiated requests (URL upload, endpoint self-checks, Unsplash, OAuth discovery) exist in both builds and are started by the site owner. - Lead with "never checks for its own updates" in both places that carried the old absolute (External services, and the FAQ answer). - Drop "Apart from that", which only existed to excuse the contradiction. - Point the FAQ answer at External services rather than implying the .org copy is silent. - CLAUDE.md: retire the "public copy has not caught up" note; docs and marketing still need the same pass. No code change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the outbound-request wording in
readme.txt, in the two places thatcarried it, and retires the matching "open task" note in
CLAUDE.md.Why
readme.txtled with:and then, two lines later:
That is self-contradictory, and
CLAUDE.md's first non-negotiable already saysso — the absolute "must state it this precisely rather than the old absolute, or
it is simply false", with the public copy marked as an open task.
What is actually true: the WordPress.org build never checks for its own
updates, because
includes/class-saddle-updater.phpis not in that zip. Thefour user-initiated requests (URL upload, endpoint self-checks, Unsplash, OAuth
discovery) exist in both builds and are started by the site owner.
How
services, and the "Does my content or my password go through your servers?"
FAQ answer).
silent.
CLAUDE.md: retire the "public copy has not caught up" note. Docs andmarketing still need the same pass.
Testing
No code change —
readme.txtandCLAUDE.mdonly; neither ships lintable PHP.Verified
grep -c "makes no outbound request at all" readme.txtis now 0, andthat the wp.org zip still excludes the updater (
grunt build→ channelwporg,includes/class-saddle-updater.phpabsent) while--channel=selfhostedstillincludes it.
Screenshots
n/a — plain-text readme.
🤖 Generated with Claude Code