Repository navigation
The docs follow where the storage authority, pointer and wheel landed - #1493
Merged
Merged
Conversation
A doc-claim audit of #1488, #1490, #1491 and #1492 found these sentences that the tree no longer supports: - plex's guide and session/persistence.rs's module doc listed cleanup_temporaries among the public calls that hand the authority and the helper's transport to a *_via form. It reads the authority and dispatches through cleanup_temporaries_for(authority), which takes no transport, because the helper arm sweeps nothing. Both now name it as the exception. - docs/module-layers.md marked L15e and L15g "planned" though W5a to W5c (#1484, #1487, #1492), W6b (#1489) and the first three W8a PRs (#1488, #1490, #1491) have landed. They now follow the L15d row's form. - docs/platform-ports.md said telemetry's sites follow in their own PR (it landed first, as #1490, and installs the account-clear sweep on every platform), said the MemoryOnly gate sits above a target_arch selection that no longer exists in plex or telemetry, and described Pointer with buttons and shown members. An as-landed note now gives W5c's Pointer { x, y, edge } and Wheel { dy: i32 } and says why the other two are not carried. - os/src/storage/mod.rs's comment on StoreError's allow(dead_code) gave a reason that stopped being true when both helper and files arms became compiled on every build. With the allow deleted no variant warns on the host or on armv7-unknown-linux-gnueabi, so the comment now says that and the attribute is left for the os directory's W8a PR to decide. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a docs follow-up to the platform plan (discussion #1460). It corrects the sentences that steps W8a (#1488, #1490, #1491) and W5c (#1492) made false. A doc-claim audit of those four PRs on
mainat fb35a0e found them. It is prose only, plus one code comment. No attribute, cfg or code line changes.What changes
rust-modules/plex/src/plex/CLAUDE.mdand thesession/persistence.rsmodule doc. Both said every public dispatcher passes the authority and the helper's transport to a*_via(authority, helper, ..)form.load,commit_data,commit_cleared,write_session,migrate_session,bootstrapandcleanup_after_confirmed_clear.cleanup_temporariesinstead dispatches throughcleanup_temporaries_for(authority), which takes no transport. ItsHelperarm isOk(()), because DB8 leaves no rename temporaries for the app to sweep.docs/module-layers.md. Two status rows were marked planned although some of their work has landed:os,src,base,storage,play-feed), then W8b and W8c, are still planned.docs/platform-ports.md:tv::authority::authority(), not above atarget_arch = "arm"selection. No such selection is left in plex or telemetry.HostEventlist gains an "As landed (W5c, Pointer and wheel reach the loop as a HostEvent, and the cursor hide is the platform's #1492)" note:Pointer { x: f32, y: f32, edge: PointerEdge }andWheel { dy: i32 }.buttonsfield, because the loop never read which button was pressed.shownfield, because that state is the pointer machine's owncur_hidden.rust-modules/os/src/storage/mod.rs. The comment onStoreError's#[allow(dead_code)]said helper-only variants are compiled out of host adapters and vice versa. Since Telemetry's consent store follows the platform's storage authority, not the build's CPU #1490 and plex's session persistence reads the platform's storage authority instead of the build's CPU #1491 every build compiles both arms. I deleted theallowand rancargo check -p plx_oson the host and on armv7, both with and withouthostsim. No variant warns, because the enum is public andlib.rsalso allowsdead_codeon all ofstorage. The comment now says that. The attribute is byte-identical; whether to drop it is a decision for theosW8a PR.Left alone
rust-modules/plex/Cargo.tomlstill describeshostsimas selecting "the simulator's session paths". Nothing inplexreadshostsimsince plex's session persistence reads the platform's storage authority instead of the build's CPU #1491. The file is certificate-pinned, and W8c removes the feature.HostEventlist'sEdit,LocaleChanged,LowMemoryandLaunch, which belong to W5b and W9.Tests
On the committed tree at bda11f0:
make test-crate C=plx_plex T=persistence:test result: ok. 101 passed; 0 failed; 0 ignored; 0 measured; 727 filtered outmake test-crate C=plx_os T=storage:test result: ok. 150 passed; 0 failed; 0 ignored; 0 measured; 312 filtered outmake check-nodef: exit 0ci/check-module-layers.py,ci/check-deps.shandci/check-statics.share green.ci/test_readonly_generated.py(22 tests) andci/test_readonly_dependencies.py(64 tests) pass.ci/proofs/*.json.🤖 Generated with Claude Code