Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fork-release.yml builds Linux x64 and macOS arm64 desktop apps and the linux-x64 CLI archive on every push to main. The macOS app is re-signed with a self-signed identity so Squirrel.Mac accepts later updates. scripts/fork/sync.sh rebases main onto each new upstream stable tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ronment (#23) delegate_task with isolation "worktree" refused target.projectId of another local project and refused every task in a linked environment. Now: - delegated_task.request takes an optional projectId. The child thread is created in that project, so launch preparation makes its worktree there, and the provider enablement check uses that project. - A local task in another project needs isolation "worktree" and branches from that project's checkout HEAD. A shared child would inherit this thread's checkout, so that case is still refused. Same-project tasks keep the parent checkout's commit. - A task in a linked environment launches there with a worktree from HEAD, which resolves in that project's checkout, so no commit that only this side has is sent. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A server built by the fork looked the same as an upstream build. Fork releases are numbered X.Y.(Z*1000+n), so a primary server version with a plain patch number of 1000 or more now gives the stage label "Fork". The default artwork mode shows a new git-branch artwork in the sidebar header, the pill mode shows a "Fork" pill, Settings > Appearance lists "Fork artwork", and the tab title reads "T3 Code (Fork)". The settings contract does not change: "artwork" follows the stage, so upstream clients still decode the setting. The artwork has its own --stage-fork-* tokens and keeps one palette in every theme. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
* fix(ci): fork releases build on Ubuntu 24.04 to keep glibc at 2.39 ubuntu-latest moved past glibc 2.39, so node-pty compiled against 2.42 and the Linux desktop build's glibc check stopped the release. The CLI archive had the same problem without a check, and would not load on Ubuntu 24.04 servers. Upstream's release jobs also pin Ubuntu 24.04. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(ci): note why fork Linux release jobs pin Ubuntu 24.04 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Enter on a model moves focus to the reasoning column, but Enter on a level only set the level and left the picker open. Enter on a level now picks it and closes the picker. The composer's close behavior then focuses the message input. Space and clicks still keep the picker open, and Enter on a model still moves to its levels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix(web): Enter on a reasoning level closes the model picker
The thread details panel showed no weekly limits unless the Usage limits row was on, and then only for the selected provider. Add a "Weekly usage rings" item, on by default, that draws each pooled weekly window across all environments as a concentric ring with the percent left beside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…al refills Code review findings: the pooled percent left could leave 0-100 in the label, labels such as "Go · Weekly" kept the word Weekly, and a pool of several accounts said "Resets in" for a reset that restores only part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Blue, orange, violet, and teal replace the pink, lime, and cyan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each ring takes its provider's bar color at the same 35% fill as the Usage page bars, so Codex reads gray and Claude rings read orange. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A provider's extra weekly windows turn its hue 45 degrees per ring, so Fable reads amber next to Claude's coral. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…p empty refills Review findings: round caps made a 95% inner ring look full, and a spent pool member's reset showed "+0%" while hiding the reset that restores. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… their reset time Review findings: a trimmed zero-length dash hid small values on inner rings, and a pool with no restoring reset showed no reset time at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feat(web): thread details show weekly usage as activity rings
The combined Pull Requests list showed every project's pull requests, so users could not follow only their own work in one repository while seeing everything in another, or leave a repository out (upstream Ideas discussion pingdotgg#27475). - Contracts: new project-scoped server setting `pullRequestFeed` (all, reviewing, authored, hidden; default all) and global `hiddenPullRequests` (URLs, max 500, compared case-insensitively). Server settings hold them, so web, desktop and mobile on one environment share the rules. - client-runtime: `pull-request-feed` resolves a project's rule and decides which rows the combined feed shows. Rules apply only when no single project is picked; hidden pull requests leave every view. - Web: the list applies the rules to its groups and keeps its flat rows consistent; hidden projects get no query. Right-click a row to hide it or set its project's rule. A quiet "Show N hidden" control and a Settings list undo hiding. The feed rule select sits next to the default merge method, so projects can override it. - Mobile: the list applies the same rules, rows get Hide from feed / Show in feed, and Settings -> Source control gets the feed rule and the hidden list. - Docs: how to set rules and unhide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…vers Review fixes for the pull request feed rules: - A hidden project now also leaves out the same repository on other environments, which otherwise took over its listing and showed the hidden rows again. - New `pullRequestFeed` environment capability. Clients offer the rule, hiding and unhiding only where the server stores them and the session can write settings, so older servers and standard pairings no longer lose the write. - Mobile builds each hide or unhide on its own writes still in flight, so quick hides no longer drop each other. Unhide is offered only where a writable environment holds the link. - The web row menu leaves links and selected text to the browser's menu. - The empty state says "Nothing under these filters" when feed rules or hidden pull requests removed the rows. - One shared `hiddenPullRequestList` helper replaces the copies in the web and mobile hooks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tory copy Review round 1 on #31: - F1: a row a later page brings lands in Others when the first-page authored and review-requested reads miss it, so an authored-only or waiting-on-me project dropped its own rows. The feed filter now also admits a row by its own classification (`groupOf`). - F2: the Load more footer counted the main list's rows, so it vanished when rules removed all of them while partition rows still showed. It now counts the rows on screen. - F3: mobile merges copies of a pull request across environments before the rules run, so a repository hidden on one environment still came through its copy on another. Mobile now rules out every copy of a repository that some environment's hidden project lists, matched on host and repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mobile learned hidden repositories from loaded rows, so a repository hidden on one environment still showed through another environment's copy when the hiding environment had returned no row for it (a truncated page or an offline environment). The shared `pullRequestRepositoryHidden` now matches the projects' repository keys, as the web query assignment does. This also removes the per-row scan on each render and the second repository key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nsaved hides Review round 2 on #31: - C1: the row menu wrote the feed rule only for the row's project, so other environments' copies of the repository kept the old rule. It now writes every project that shares the repository key, as Settings does. - X1: the web feed also rules out rows whose repository any environment's project hides, and with no projects left to read the list shows no carried rows. - X2: the search empty state offers Load more while the results have more pages. - X3: mobile keeps a successful hidden-list save as the base for the next hide or unhide until the settings subscription replaces the stored list. - X4: the web empty state counts as filtered when a project is hidden. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of the round 2 fixes: - The row menu writes the rule only to copies whose environment can store it, and only connected environments' hidden projects remove a repository, so a rule this client cannot change cannot trap it. - Mobile treats an interrupted or rejected hidden-list save as unsaved, and keeps a saved list until the stored list's contents change, not its array identity. - The page drops carried rows only when feed rules leave every project out, not while environments or projects are still loading. - The filtered empty state points at the projects' feed rules too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review round 3 on #31: - Web queries left a repository out when any environment with a cached config marked a copy hidden, including offline and read-only ones, while the rows counted only connected environments. One shared rule, `pullRequestProjectHidesRepository` (connected and writable), now decides which projects hide their repository, for the web query assignment, the web rows and the mobile rows. - A mobile hidden-list save now ends at the first change of that environment's stored list, confirmed or superseded, so it cannot reapply over another client's later unhide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A hide or unhide sent while an earlier save was unanswered inherited that save's base, so the earlier echo ended the newer save. The hide then looked undone, and a further hide in that window could drop it on the server. Each save now keeps every list that preceded it in its chain, and ends only on an update outside the chain. The feed also subscribes to the workspace environments alone, and treats an environment as connected only once its server config has arrived, as web does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review round 4 on #31. `hiddenPullRequests` was a whole array, so every hide and unhide rewrote the full list, and writes from the feed, Settings, another client or a queued save could erase each other. - `hiddenPullRequests` is now a record keyed by lowercased pull request URL with the value `true`. A patch sets `true` to hide and `null` to show again, and the server merges it entry by entry (`mergeSettingsEntries`), so no write reads or replaces the others. The record only holds hidden links; its size is left unbounded. - Removed what the record makes unnecessary: the list rewrites (`withHiddenPullRequest`, `withoutHiddenPullRequest`), the drop-oldest limit, mobile's pending-save chain and the writer's failure reporting. Web's optimistic overlay now applies single keys. - A project's `hidden` rule now hides its repository whenever its environment is connected; write access gates only changing rules and hiding or unhiding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… on mobile Review of the record change: - Each hidden link now stores the URL as the user hid it, keyed by its lowercased form, so Settings shows and opens it unchanged on hosts with case-sensitive paths. - The server lowercases stored keys as well as patch keys when it merges, so a stored link in any spelling can be unhidden. - Mobile overlays each hide or unhide on its own key until the write settles, so the row responds at once, as on web. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngs, unhide needs every holder Review round 5 on #31: - The "Show N hidden" state turns off once nothing is hidden, on web and mobile, so the next hide does not stay on screen with the toggle gone. - A mobile hide or unhide now shows until the target environment's settings change after a successful save, as web's pending writes do, and drops at once when the save fails. - Unhide is offered only when every environment that holds the link is connected and writable; otherwise it is disabled and names the environment that keeps the link hidden. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…al updates Review of the round 5 fixes: - "Show hidden" now turns off only when nothing is hidden anywhere, not while a view loads or has no hidden rows. - A mobile unhide across several holders shows until every holder has pushed its settings, not just the first. - A save's reply settles only its own entry, never a later send for the same link, and answered entries leave the overlay at the next send. - The sent-entry type is keyed by environment id, without a cast. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ver's state Review round 6 on #31: - Mobile applied the feed rules after merging the copies of a pull request that several environments list, so the kept copy could fail its own environment's rule and hide one that another environment allows. Each copy now meets its own environment's rule first, and the merge picks among the copies that pass. - A mobile hide or unhide now ends per target environment when its settings already show the sent state (even if that push beat the reply), when its save fails, or at any settings update after a successful reply. A stale unhide can no longer mask a later re-hide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of the round 6 fixes: - A sent hide or unhide now drops each answered target from state for good, so another client's later change cannot revive it before the reply. A token, not the entry object, ties the reply to its send. - The settled check matches the stored link in any spelling. - Any failed holder ends the whole send, since that holder still hides the link. - The screen classifies each copy once and reuses it; restored the two-holder test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… keep Load more Review round 7 on #31: - Web judged a row only by the rule of the environment that owned its repository. The feed option is now `rulesFor`: a row shows when any connected copy of its repository allows it, matched on the canonical repository key (`pullRequestRepositoryRules`). Mobile uses the same helper, which replaces its filter before the copies merge. - When one environment's request fails and the feed rules empty another environment's truncated page, the error view keeps the Load more footer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…to the feed The involved listing ruled with one cutoff across every repository, read whole environments, and only filtered rows the broad list had loaded. Now the cutoff is per project and a tie or a failed slice fails open, the read covers only projects on the rule, and its rows join the feed like the authored and reviewing partitions. Web holds the last answer while a refresh travels. Mobile waits for every target, skips the read while searching, and fails open on any error. GitHub's search-free fallback answers `involved` with an empty truncated page, and a settings write keeps a strict feed rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] packages/client-runtime/src/pullRequestFeed.ts:123 On GitLab, Azure DevOps, Bitbucket, Forgejo, GitCafe and Cursor Origin, "Involving me" ends up showing every pull request in a large repository. The pull requests these hosts treat as yours are only the ones you opened or must review, and the client already knows both from the row itself. Here is how it fails. The service reads one F2 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 Carried over from gpt F5 (#33 (comment)). Say one repository is a project on two environments, and the list reads it through copy A while copy B is on F3 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 Carried over from gpt F7 (same comment). The involved membership read mounts the full F4 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:932 The new F5 [nit] packages/contracts/src/settings.ts:1570 The forward-compatible decode only protects future clients. An installed older mobile or web build still decodes Fixes from the earlier reviews that I checked against this head:
I could not run typecheck or the test suites because the checkout has no dependencies. The only check I ran was the matcher logic in plain Node, for F1. |
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [blocker] packages/client-runtime/src/pullRequestFeed.ts:123 In a large GitLab or Bitbucket repository, the server can return an empty, truncated F2 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 Mobile merges GitHub’s F3 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:803 Carried over from F2. If an involved refresh fails after a successful read, the held answer can still hide a PR the viewer just commented on, even when the main list refresh succeeds. Fix: Keep previously listed rows visible and treat absent rows from the failed lookup as unknown. Prior review F4 [should] apps/web/src/components/pullRequest/pullRequestListGroups.logic.ts:118 Carried over from F1. A successful involved answer is discarded when either the authored or reviewing lookup has no answer. If the reviewing request fails on initial load, a PR returned by the involved lookup beyond the main page stays missing. Fix: Merge involved candidates when grouping falls back to the main list. Prior review F5 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 Carried over from F5. If the main list assigns a shared repository to an Authored checkout, the Involving me checkout can be skipped by the membership lookup even though its rule still applies. The matcher then admits every row as unknown. Fix: Build membership targets from the checkouts whose rules count and evaluate membership across those copies. Prior review F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 An environment with more than 100 projects on the rule sends a F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 Carried over from F7. The secondary list hook fetches diff stats for its first eight rows even when deduplication or feed filters remove them from the screen. Fix: Let the primary list request stats for the rows it displays. Prior review F8 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:932 The new Focused Node checks confirmed F1, F3, and F4. |
…lvement On a host that cannot narrow `involved`, the read was a filtered `all` page, so every Others row failed open and the rule did nothing. The server now skips that read and marks each provider with `listsInvolved`; clients rule Others rows out on hosts without it. Paging is read per repository from the cursor keys, an environment that has not answered or failed is unknown, and GitHub treats an empty `involves:` search as an answer only where search covers the repository. Mobile also joins the review-requested list (which `involves:` omits) and refreshes both extra lists on pull to refresh. Web merges involved rows when an authored or reviewing read has no answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] packages/source-control-github/src/server/GitHubPullRequestProvider.ts:437 The way the provider signals "unindexed repository" usually doesn't reach the client, so the client hides rows the PR says it should show. For an uncovered repository, the provider returns F2 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:486 On web, F3 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:381 Carried over: earlier Claude F2 and gpt F5 (#33 (comment), #33 (comment)). Say a repository is a project on two environments, the main list reads it through copy A, and copy B is on F4 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:53 Carried over: earlier Claude F3 and gpt F7 (same comments). There are now two extra full F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:42 Carried over: gpt F6 (#33 (comment)). Mobile does not split F6 [nit] packages/contracts/src/settings.ts:1567 Carried over: earlier Claude F5 (#33 (comment)). The forgiving decode only helps clients built from this version. An installed older web or mobile build still decodes Fixes I checked against this head:
I also ruled out a suspected render loop around I couldn't run typecheck or the test suites because the checkout has no dependencies installed. The only check I ran was the plain-Node copy of the matcher for F1. |
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] packages/client-runtime/src/pullRequestFeed.ts:117 Search still hides unrelated PRs on GitLab and other hosts without F2 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:260 On GitLab, the feed can be empty even when you have open PRs. If your newest authored PR is beyond the first broad page, the reviewing lookup cannot surface it and the involved lookup is skipped by the server. Fix: Merge authored results for projects on hosts without F3 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:423 Load more advances only the broad list on both clients. Once it passes the first involved page’s cutoff, older unrelated PRs remain visible because the membership lookup never advances. Fix: Advance the involved lookup as the feed loads older rows, keeping uncertain rows visible until it answers. F4 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:830 When two involvement refreshes fail, the merged query reports only the first error. The second environment’s cached answer can still hide a PR the viewer just commented on. Fix: Track failed targets separately and use cached answers from those targets only to confirm matches. Carried over from F3. F5 [nit] packages/client-runtime/src/pullRequestFeed.ts:135 An unindexed GitHub repository returns an empty, truncated result without a cursor. If another repository in that environment supplies a cursor, the matcher treats the unindexed repository as complete and hides its Others rows. Fix: Carry the unknown status per repository independently of cursors. F6 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 If the main list assigns a shared repository to an Authored checkout, the Involving me checkout can be omitted from the membership lookup even though its rule still applies. Unrelated rows then pass as unknown. Fix: Query the checkouts whose rules count and evaluate their membership by repository. Carried over from F5. F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 A server with more than 100 projects on the rule receives a F8 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 The two secondary list hooks can fetch diff stats for rows removed by deduplication or filtering. Fix: Let the displayed list request stats for visible rows. Carried over from F7. F9 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:430 One pull-to-refresh can invalidate the same server’s provider and viewer caches three times. Fix: Invalidate once per environment, then refresh the affected lists. F10 [nit] packages/contracts/src/settings.ts:1570 Installed older clients still reject the settings snapshot once an upgraded server stores Focused Node checks reproduced the matcher behavior behind F1, F3, F4, and F5. |
…t and repository An uncovered GitHub repository now fails its empty `involved` read, so its rows count as unknown instead of hiding behind another repository's cursor. Servers always send `listsInvolved`; a missing value from an older server counts as unknown, and web reads it per environment. Mobile also joins the authored list, as web's partitions do, because a host without `listsInvolved` answers `involved` with nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] packages/client-runtime/src/pullRequestFeed.ts:117 Carried over from gpt F1 (#33 (comment)); there is no author reply, and the code at this head is unchanged. While the user searches, neither client reads F2 [nit] packages/client-runtime/src/pullRequestFeed.ts:139 Carried over from gpt F3 (#33 (comment)). Only the first page of F3 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:838 Carried over from gpt F4 (#33 (comment)). F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 Carried over from Claude F3 and gpt F6 (#33 (comment), #33 (comment)); this code is unchanged. Suppose one repository is a project on two environments, the main list reads it through copy A, and copy B is on F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 Carried over from Claude F4 and gpt F8 (same comments). There are now three extra full F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:201 Carried over from Claude F5 and gpt F7 (same comments). F7 [nit] packages/contracts/src/settings.ts:1570 Carried over from Claude F6 and gpt F10 (same comments). The forgiving decode only helps clients built from this version. Once another client stores Fixes I checked against this head:
I couldn't run typecheck or the test suites because the checkout has no |
…m its listings The matcher guessed which rows the involved listing had ruled on from cursors, truncation and per-repository cutoffs. Now a project on the rule shows only rows its involved, authored and review-requested listings hold. Until its involved read is ready (answered, not failed, the project read without error; an unindexed GitHub repository fails), its rows show as under the All rule. A search bypasses the rule, and Load more grows the involved read on web and mobile. Hosts without `listsInvolved` answer `involved` with nothing, so their rows come from the authored and review-requested reads; the `listsInvolved` field on provider summaries is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [blocker] packages/client-runtime/src/pullRequestFeed.ts:271 On web and desktop, Involving me shows unrelated Bitbucket and Forgejo PRs. Both providers return ordinary rows for the authored and reviewing reads, and the feed trusts the resulting priority group before checking the row’s author or review request. Fix: On fallback hosts, evaluate authorship and review requests from the row itself. Carried over from F1, with new evidence that rows still pass through priority grouping. F2 [should] packages/client-runtime/src/pullRequestFeed.ts:117 Search still hides matching unrelated PRs on GitLab and other fallback hosts. Both clients skip the involvement lookup during search, but the matcher still rejects rows when F3 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:430 Load more advances only the broad list on both clients. Once it passes the first involvement page’s cutoff, older unrelated PRs remain visible because their membership is never checked. Fix: Advance the involvement lookup as older feed rows load, keeping uncertain rows visible until the lookup answers. Carried over from F3. F4 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:838 When two involvement refreshes fail, only the first environment is marked unknown. The second environment’s cached answer can still hide a PR the viewer just commented on. Fix: Track failed targets individually and use their cached answers only to confirm matches. Carried over from F4. F5 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 Assigning a shared repository to an Authored checkout can omit the checkout whose Involving me rule still applies. Unrelated rows then pass as unknown. Fix: Build involvement targets from the checkouts whose rules count and match coverage by repository. Carried over from F6. F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 On an environment with more than 100 projects on the rule, the involvement lookup exceeds the RPC’s F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 The three secondary list hooks can request diff stats for rows the feed drops during deduplication or filtering. Fix: Fetch stats only for rows displayed by the combined list. Carried over from F8. F8 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:436 One pull-to-refresh can invalidate the same environment’s provider and viewer caches four times. Fix: Invalidate once per environment, then refresh its lists. Carried over from F9. F9 [nit] packages/contracts/src/settings.ts:1570 Older installed clients still reject the settings snapshot once an upgraded server stores F10 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1968 The empty-result fallback discards truncation from the search, which can occur when GitHub repeats a cursor. A repository with cached search coverage then looks fully read, so the matcher can hide PRs from unread pages. Fix: Preserve truncation and mark that repository’s coverage unknown when there is no usable cursor. Focused Node checks reproduced the grouping and matcher behavior behind F1–F4. |
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] apps/web/src/components/pullRequest/pullRequestList.logic.ts:459 Carried over from gpt F1 (#33 (comment)). That review called it a blocker. I rate it should because GitHub, the main case, works. There is no reply from the author, and this head still has the problem. On web, "Involving me" shows every pull request of Bitbucket and Forgejo projects, and of Cursor Origin projects for the review-requested part. The PR says these hosts show only authored and review-requested rows. Here is why. F2 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:696 Load more on web grows the involved read by raising its limit, not by following a cursor, and the limit stops at F3 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 Carried over from Claude F4 and gpt F5 (#33 (comment), #33 (comment)). Take one repository that is a project on two environments. The main list reads it through copy A, and copy B is on F4 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:191 Carried over from Claude F6 and gpt F6 (same comments). The F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:217 Carried over from Claude F5 and gpt F7 (same comments). There are three extra full F6 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1961 Carried over from gpt F10 (#33 (comment)). The empty These earlier findings are fixed at this head:
I could not run typecheck or tests because the checkout has no |
…es a failed page Web grew the involved read only when its last answer said truncated, so a click during a pending read advanced only the main list. It now grows with every Load more, and at its largest page the rows older than its oldest listed row show, since it cannot reach them. Mobile retries a failed involved page on the next request and shows its error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [blocker] packages/client-runtime/src/pullRequestFeed.ts:232 Web and desktop show unrelated PRs under Involving me on Bitbucket and Forgejo. Both providers return unfiltered rows for the authored and reviewing reads, and the feed accepts the resulting group even when the row itself is unrelated. Carried over from F1. Fix: For Involving me, check the row’s author and review-request flag before accepting it through a priority group. F2 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:697 Load more stops adding GitHub involvement matches after 100 rows per search batch. The client increases the limit without sending the involved cursor, and the server caps each batch at 100. Older PRs where the viewer only commented, was mentioned, or was assigned stay hidden. Fix: Advance the involved listing with its own F3 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:515 A failed involved page leaves a Load more button that silently does nothing. The footer only checks the main list’s error, while the involved list refuses to retry without F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 When the same repository has an Authored checkout and an Involving me checkout, assigning the main read to the Authored checkout can omit the other checkout’s involvement lookup. Unrelated rows then pass as unknown. Carried over from F5. Fix: Evaluate membership and readiness across the checkouts whose rules count. F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 More than 100 projects on the rule in one environment causes all three secondary reads to exceed the RPC’s F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 Each secondary list can fetch diff stats for its first eight rows, including rows discarded by deduplication or filtering. Carried over from F7. Fix: Fetch stats through the combined list’s visible-row handler. F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:445 One pull-to-refresh can invalidate the same environment’s provider and viewer caches four times. Carried over from F8. Fix: Invalidate once per environment before refreshing its lists. F8 [nit] packages/contracts/src/settings.ts:1570 Older installed clients still reject the settings snapshot once an upgraded server stores F9 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1968 The empty involved fallback discards the search’s truncation flag. If search stops early with no usable rows and the repository has cached coverage, the client treats the incomplete answer as empty and hides its rows. Carried over from F10. Fix: Preserve truncation and fail the project read when an incomplete answer has no usable cursor. Focused Node checks reproduced F1–F3, and |
…y a truncated read The floor for a capped involved read was merged across repositories and could come from a held, smaller answer, so it hid rows it meant to show. It is gone: the read stops at 500 rows per environment, a stated limit. Web grows the involved read only when its answer was truncated (or a grown read is still in flight), and mobile reruns a failed involved page only on an explicit retry, with a spinner while either list loads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] apps/web/src/components/pullRequest/pullRequestList.logic.ts:459 Carried over from gpt F1 (#33 (comment)) and Claude F1 (#33 (comment)). There is no author reply, and the code is unchanged at this head. On web, "Involving me" still shows every pull request of a Bitbucket or Forgejo project. The cause is that neither provider reads F2 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:697 Carried over from gpt F2 (#33 (comment)). The latest commit makes every Load more grow the involved read, but it still raises only F3 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:838 At 500, F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 Carried over from Claude F3 (#33 (comment)) and gpt F4 (#33 (comment)). The code is unchanged. Take a repository that is a project on two environments. If the main list reads it through copy A and copy B is on F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:191 Carried over from Claude F4 and gpt F5 (same comments). F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:217 Carried over from Claude F5 and gpt F6/F7 (same comments). Each of the three extra F7 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1968 Carried over from Claude F6 and gpt F9 (same comments). The empty F8 [nit] packages/contracts/src/settings.ts:1570 Carried over from gpt F8 (#33 (comment)). The forgiving decode helps only clients built from this version. An installed older client still fails to decode the whole settings snapshot once I confirmed these from the code at this head:
I did not run typecheck or tests because the checkout has no dependencies installed. F1 and F2 come from reading the provider, search and grouping code, not from running them. |
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [blocker] packages/client-runtime/src/pullRequestFeed.ts:232 On web and desktop, Involving me admits unrelated Bitbucket and Forgejo PRs because their unfiltered partition responses label them as authored or review-requested. Cursor Origin has the same problem for review requests. Fix: For fallback providers, verify the row’s author and review-request flag before admitting it. Carried over from F1. F2 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:698 Load more raises the limit without sending a cursor, so GitHub’s batched search rereads the same first 100 rows. At the new cap, one old result from another repository can still cause an unread match to be hidden even after the broad list reaches it. Fix: Follow the involved listing’s own cursors, append its rows, and track any remaining coverage gaps per repository. Carried over from F2. F3 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:245 Load more never advances the authored or reviewing lists. On GitLab, for example, the 31st authored PR can sit beyond many pages of unrelated activity, forcing the user to page through the broad list to reach it. Web also keeps these partitions at their initial limit. Fix: Advance the authored and reviewing partitions that supply Involving me rows when those partitions have more results. F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 If an Authored checkout owns the main read for a shared repository, the Involving me checkout can be omitted from the lookup. The selected copy then fails open and shows unrelated PRs. Fix: Read the copies whose rules count and evaluate readiness by repository. Carried over from F4. F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 More than 100 projects on the rule in one environment makes the server reject all three secondary reads. Web can hit the same limit when its main target covers the whole environment. Fix: Split project IDs at the RPC limit and track readiness per batch. Carried over from F5. F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 The three secondary hooks can fetch diff stats for rows the combined feed discards, and pull to refresh can invalidate the same environment four times. Fix: Fetch stats through the visible list and invalidate each environment once per refresh. Carried over from F6 and F7. F7 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:831 When a grown read spans two environments, the first reply replaces the entire held answer. Rows found only by the slower environment’s involved listing disappear until it replies. Fix: Retain the previous answer for each environment until its replacement arrives. F8 [nit] packages/contracts/src/settings.ts:1570 Older installed clients reject the settings snapshot after an upgraded client saves F9 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1968 The empty involvement fallback discards the search’s truncation flag. If search stops early without usable rows and coverage is cached, the project looks fully read and its rows can be hidden. Fix: Preserve truncation and fail the project read when an incomplete answer has no usable cursor. Carried over from F9. Focused Node checks reproduced F1 and F2. |
…r was complete The involved read grew only on a truncated answer, so it could stall while the main list grew, and a failed read kept the button growing it. It now grows with each Load more unless its latest answer is complete, Load more stays offered while only the involved read can grow, and a complete main list is not read again for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] packages/client-runtime/src/pullRequestFeed.ts:232 Carried over from gpt F1 (#33 (comment)) and Claude F1 (#33 (comment)). There is no author reply, and the code is the same at this head. On web, Involving me still shows every PR of a Bitbucket or Forgejo project. Neither provider reads F2 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:696 Carried over from gpt F2 and Claude F2 (same comments), with new evidence against the new
So each Load more raises the limit from 99 to 198, then 297, 396, 495 and 500, and every time it fetches the same first 100 rows with F3 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:648 F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 Carried over from Claude F4 and gpt F4 (same comments). The code is unchanged. Take a repository that is a project on two environments. If the main list reads copy A and copy B is on the rule, F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:191 Carried over from Claude F5 and gpt F5 (same comments). F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:217 Carried over from Claude F6 and gpt F6 (same comments). Each of the three extra F7 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1968 Carried over from Claude F7 and gpt F9 (same comments). The empty F8 [nit] packages/contracts/src/settings.ts:1570 Carried over from Claude F8 and gpt F8 (same comments). The forgiving decode helps only clients built from this version. An older installed client still fails to decode the settings snapshot once These are fixed at this head:
I confirmed F1 and F2 by reading the provider, service and search code. I did not run typecheck or tests, because the checkout has no dependencies installed. |
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [blocker] packages/client-runtime/src/pullRequestFeed.ts:232 Involving me shows unrelated PRs on web and desktop for Bitbucket and Forgejo because their unfiltered partition responses label those rows as authored or review-requested. Cursor Origin has the same issue with its reviewing partition. Fix: Check the row’s author and review-request flag before admitting it through a partition from these providers. Carried over from F1. F2 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:700 Load more raises the limit without sending the involved listing’s cursor. GitHub’s batched search then returns the same first 100 matches, leaving older PRs where the viewer only commented, was mentioned, or was assigned hidden. Fix: Follow the involved listing’s F3 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:245 Load more leaves the authored and reviewing partitions on page one on both clients. On GitLab, reaching the 31st authored PR on mobile can require paging through many pages of unrelated activity. Fix: Advance the authored and reviewing partitions that supply Involving me rows, and include them in the footer’s pagination state. Carried over from F3. F4 [nit] apps/web/src/components/pullRequest/pullRequestListGroups.logic.ts:118 If the authored request fails before its first answer, web also drops the successful reviewing results. A review-requested PR beyond the broad page then stays missing. Fix: Merge each available partition independently. F5 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:452 If an Authored checkout owns the main read for a shared repository, the Involving me checkout can be left out of the lookup. Every unrelated row then passes as unknown. Fix: Query the checkouts whose rules apply and match readiness by repository. Carried over from F4. F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 An environment with more than 100 projects on the rule exceeds the RPC’s F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 The three secondary hooks can fetch diff stats for rows the feed discards, and pull to refresh can invalidate the same environment four times. Fix: Fetch stats through the combined list’s visible-row handler and invalidate each environment once per refresh. Carried over from F6. F8 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:834 The first environment to answer a larger read replaces the entire held answer. Rows supplied by a slower environment’s involved listing disappear until it replies. Fix: Retain each environment’s previous answer until its replacement arrives. Carried over from F7. F9 [nit] packages/contracts/src/settings.ts:1570 Older installed clients can reject the whole settings snapshot after an upgraded client saves F10 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1968 The empty involved fallback discards the search’s truncation flag. If search stops early without usable rows and coverage is cached, the project appears fully read and its rows can be hidden. Fix: Preserve truncation and fail the project read when an incomplete answer has no usable cursor. Carried over from F9. F11 [nit] packages/client-runtime/src/pullRequestFeed.ts:80 The Focused Node checks reproduced F1, F2, and F4. |
Web's involved read grew only its limit, so GitHub's 100-row search chunk returned the same rows on every Load more. A small paged-list hook now follows each listing's own `nextCursors` and adds its pages up; for projects on the rule it pages the involved, authored and review-requested reads together. One `pullRequestLoadMore` helper turns the main and involved read states into what Load more grows and what the footer shows, so a page in flight is never restarted and a failed page retries. Hosts that ignore `authored` and `reviewing` (Bitbucket, Forgejo, Cursor Origin) sent every row into those partitions; the server now keeps only rows whose author or review requests involve the viewer outside GitHub. GitHub's empty `involved` fallback fails when its batch was truncated. Mobile advances the authored and review lists with Load more too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] apps/web/src/components/pullRequest/PullRequestsPage.tsx:742 The main list stops paging whenever any environment's read is failing. If F2 [should] apps/web/src/components/pullRequest/usePagedHostList.ts:96 The new paged listings have the same problem. F3 [nit] apps/web/src/components/pullRequest/pullRequestList.logic.ts:467 Rows that only the paged F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:871 One failed Load more page of the involved listing adds its environment to F5 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:458 Carried over from Claude F4 (#33 (comment)); the code is unchanged. Take a repository that is a project in two environments. If the main read covers copy A and copy B is the one on the rule, F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 Carried over from Claude F5 (same comment). F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:217 Carried over from Claude F6 (same comment). The three secondary F8 [nit] packages/contracts/src/settings.ts:1570 Carried over from Claude F8 (same comment). The forgiving decode helps only clients built from this version. An older installed client still fails to decode the settings snapshot once F9 [nit] packages/client-runtime/src/pullRequestFeed.ts:80 Carried over from gpt F11 (#33 (comment)). The These earlier findings are fixed at this head:
I found F1 and F2 by reading the code ( |
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] apps/web/src/components/pullRequest/usePagedHostList.ts:84 A live refresh or completed turn can erase older GitHub matches the user already loaded. The refresh raises the initial limit, but GitHub still returns at most 100 rows per search batch. The hook replaces all accumulated pages with that first batch. Fix: Keep the loaded pages visible while the refresh follows cursors through the previously loaded range. F2 [should] apps/web/src/components/pullRequest/usePagedHostList.ts:66 Paging a healthy repository clears earlier errors for every repository in the same environment. An unindexed GitHub repository then starts hiding its PRs even though its involvement lookup never succeeded. Fix: Replace errors only for repositories the new page actually read. F3 [should] apps/web/src/components/pullRequest/usePagedHostList.ts:96 A repository-level error on a continuation is returned inside a successful RPC response, so the pager can mark the listing complete and remove Load more after a transient failure. Fix: Keep the failed repository’s request cursor and make that page retryable. F4 [should] apps/server/src/pullRequest/PullRequestService.ts:1453 The new login check drops GitCafe PRs that the provider correctly matched by actor ID when the viewer’s linked GitHub login differs from their GitCafe handle. These PRs disappear from Involving me and the existing web Authored by me feed. Fix: Preserve provider-verified authorship and use login matching for providers that return unfiltered rows. F5 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:458 When an Authored checkout owns the main read for a shared repository, the checkout set to Involving me can be left out of the lookup. Unrelated PRs then pass as unknown. Fix: Query the checkouts whose rules apply and match readiness by repository. Carried over from F5. F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 More than 100 projects on the rule in one environment can make all three lookups exceed the RPC’s project ID limit. Web has the same issue when its main query covers the whole environment. Fix: Split requests at F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 The three secondary hooks can fetch diff stats for rows the feed discards, and pull-to-refresh can invalidate the same environment four times. Fix: Fetch stats through the visible list and invalidate each environment once per refresh. Carried over from F7. F8 [nit] packages/contracts/src/settings.ts:1570 Older installed clients can reject the whole settings snapshot after an upgraded client saves F9 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1963 The new guard catches an empty truncated initial repository read, but continuation reads bypass it. An empty truncated continuation has no row from which to build a cursor, so web can silently end the listing. Fix: Treat empty truncated F10 [nit] packages/client-runtime/src/pullRequestFeed.ts:80 The Focused Node checks reproduced F1–F4, and |
…n its own One failed environment marked the whole main list or paged listing as failed, so Load more only refreshed and healthy environments never left page one. The main list now fails only when no environment can continue, and the paged listings advance environments with cursors while retrying only the failed ones. Paged pages merge through one tested helper: a first page replaces rows in its span and keeps older loaded rows with the deeper cursor, a continuation clears only the errors of projects it read, and a continuation that failed for a passing reason offers its cursor again from the server. The login check now runs only for providers that declare they ignore an involvement (Bitbucket, Forgejo, Cursor Origin for reviewing, GitCafe for unnarrowed reviewing), so rows a provider matched another way stay. Rows only the paged authored and review listings bring join their own group, and the unused `involved` tab case is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] apps/web/src/components/pullRequest/pullRequestLoadMore.logic.ts:97 When an environment holds several projects with their own cursors, a refresh drops pages the user already loaded, and Load more never brings them back. F2 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:861 Carried over from Claude F4 (#33 (comment)). If one Load more page of the involved listing fails at the RPC level, F3 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:454 Carried over from Claude F5 (#33 (comment)) and gpt F5 (#33 (comment)). The code is unchanged. Take a repository that is a project in two environments. If the main read covers copy A and copy B is the one on the rule, F4 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:195 Carried over from Claude F6 and gpt F6 (same comments). F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 Carried over from Claude F7 and gpt F7 (same comments). The three extra F6 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1963 Carried over from gpt F9 (#33 (comment)). The empty-and-truncated guard skips continuations ( F7 [nit] packages/contracts/src/settings.ts:1570 Carried over from Claude F8 and gpt F8 (same comments). The forgiving decode only helps clients built from this version. An older installed client still rejects the settings snapshot once These earlier findings are fixed at this head:
I ran F1's reproduction with Node 22 type stripping on a copy of |
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] apps/web/src/components/pullRequest/pullRequestLoadMore.logic.ts:97 A refresh can discard loaded GitHub matches from a busy repository when a quiet repository in the same environment returns an older first-page row. The merge drops the busy repository’s rows using the quiet repository’s timestamp, then keeps the busy repository’s deeper cursor, so Load more skips the dropped rows. Fix: Reconcile refreshed rows and cursors using each repository’s actual first-page coverage. Carried over from F1, with the gap reproduced in the new merge helper. F2 [should] apps/web/src/components/pullRequest/usePagedHostList.ts:83 A transient repository error on a continuation comes back in a successful RPC response with the same cursor. When that repository is the only target left, Load more selects the same cached query and never refreshes it because F3 [should] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:312 GitCafe can correctly return a synced PR in the authored listing by actor ID, but mobile drops it when the linked GitHub login differs from the GitCafe handle. Web does the same for rows found only on later authored pages. Fix: Preserve provider-confirmed membership from the authored and reviewing listings through deduplication and feed filtering. The server-side fix from F4 preserves the row, but the clients still discard it. F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:454 When an Authored checkout owns the main read for a shared repository, a second checkout set to Involving me can be left out of the lookup. The rule then admits unrelated rows because membership is unknown. Fix: Query the checkouts whose rules count and resolve membership by repository. Carried over from F5. F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:203 More than 100 projects on the rule in one environment exceeds the RPC’s project ID limit for all three secondary reads. Web can hit the same limit when the broad read covers a whole environment. Fix: Batch requests at F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:206 The three secondary hooks can fetch diff stats for rows the feed discards, and pull-to-refresh can invalidate the same environment four times. Fix: Fetch stats for visible rows and invalidate each environment once per refresh. Carried over from F7. F7 [nit] packages/contracts/src/settings.ts:1570 An older installed client can reject the entire settings snapshot after an upgraded client saves F8 [nit] packages/source-control-github/src/server/GitHubPullRequestApi.ts:1963 An empty, truncated GitHub continuation bypasses the new guard and can end pagination because the server has no row from which to build a cursor. Fix: Treat empty, truncated Focused Node checks reproduced the state behind F1–F3. |
The Load more paging of the involved, authored and review-requested listings is removed on web and mobile, with its hook, its merge helpers and the server's retry cursor. Involving me reads one page of each (99 rows, on GitHub per search chunk of 100 repositories), a limit the docs and a `lean:` comment now state. The source model, per-project fail-open, search bypass and the `ignoresInvolvement` check stay, and the main list's Load more keeps the per-environment failure handling. A row an authored or review-requested listing returned now keeps that group on mobile, so a GitCafe pull request matched by actor is not dropped when its GitHub login differs from the GitCafe handle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note claude-opus-5-5 responding on behalf of Ilkka Automatic review of VERDICT: APPROVE F1 [nit] apps/web/src/components/pullRequest/pullRequestLoadMore.logic.ts:807 F2 [nit] packages/source-control-gitcafe/src/server/GitCafePullRequestProvider.ts:799 GitCafe declares only F3 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:453 Carried over from Claude F3 (#33 (comment)); the logic is unchanged. Take a repository that is a project in two environments. If the main read covers copy A and copy B is the one on the rule, F4 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:213 Carried over from Claude F4 (same comment). F5 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:220 Carried over from Claude F5 (same comment). The three extra F6 [nit] packages/contracts/src/settings.ts:1570 Carried over from Claude F7 (same comment). The forgiving decode only helps clients built from this version. An older installed client still rejects the whole settings snapshot once Earlier findings that no longer apply at this head:
I read the code paths without running them. Repository tests and typecheck were not run, because the checkout has no installed dependencies. I also could not confirm that |
|
Note gpt-6.2-sol responding on behalf of Ilkka Automatic review of VERDICT: CHANGES F1 [should] apps/web/src/components/pullRequest/pullRequestListGroups.logic.ts:118 Web discards a successful review-requested listing while the authored listing is pending or has failed, and vice versa. A PR returned only by the successful listing disappears from Involving me. Fix: Merge each available listing independently. F2 [should] packages/client-runtime/src/pullRequestFeed.ts:95 Both clients admit authored and review-requested rows from the broad list even when those rows are absent from all three listings. Load more can therefore reveal older PRs that the documented one-page limit says stay hidden. Fix: For ready projects, require URL membership in the union of the three listings. F3 [nit] packages/source-control-gitcafe/src/server/GitCafePullRequestProvider.ts:825 A transient principal lookup failure can return an unfiltered authored page. The service passes that page through, and both clients treat unrelated PRs from it as authored. Fix: Filter by login when the actor ID is unavailable and preserve actor matching when it is available. F4 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:708 Load more still stalls when one environment fails and a healthy environment reports truncation without a cursor, as GitHub’s repository fallback can. Each click retries the same limit. Fix: Grow the healthy environment’s request and leave the failure to the Retry action. Carried over from F1. F5 [nit] apps/web/src/components/pullRequest/PullRequestsPage.tsx:453 When the broad list assigns a shared repository to a checkout with an Authored rule, it can omit the checkout with an Involving me rule from the lookup. The shared repository then shows unrelated PRs. Fix: Query the checkouts whose rules apply and match readiness by repository. Carried over from F4. F6 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:210 More than 100 projects on the rule causes the RPC to reject all three mobile lookups. Web can hit the same limit when the broad query covers a whole environment. Fix: Batch project IDs at the RPC limit and track readiness per batch. Carried over from F5. F7 [nit] apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx:220 The secondary hooks can fetch diff stats for discarded rows, and pull-to-refresh can invalidate the same environment four times. Fix: Fetch stats for visible rows and invalidate each environment once per refresh. Carried over from F6. F8 [nit] packages/contracts/src/settings.ts:1570 An older installed client can reject the entire settings snapshot once an upgraded client saves Focused Node checks reproduced F1–F4. |
Problem
In a large repository, the combined Pull Requests feed shows every pull request. The rules from #31 can narrow a project to authored or review-requested pull requests, but not to all the pull requests the user takes part in: ones they opened, ones waiting on their review, and ones where they are assigned, mentioned, or have commented.
Change
involved, labelled "Involving me". It is inPullRequestFeedRuleandPULL_REQUEST_FEED_RULES, andpullRequestFeedShowshandles it. It shows authored and review-requested rows, and an Others row only when that row's project's involved listing holds it (theinvolvedcallback inPullRequestFeedOptions).pullRequestInvolvedMatcher).lean:comments on web and mobile name the trigger to revisit: users who need their older involved pull requests. Picking the project in the list's project filter shows all of its pull requests.involvedread with a per-project error. So does an emptyinvolves:search whose batch says it has more. Either way, that project falls back to All.ignoresInvolvementfor the listings it answers with every row: Bitbucket and Forgejo (authoredandreviewing), Cursor Origin (reviewing), and GitCafe (reviewing, which is unnarrowed when its principal cannot be read). For those providers only, the server keeps a row when its author or its review requests involve the viewer. Other providers' rows stay as sent. On mobile, a row that an authored or review-requested list returned keeps that group even when its author login is not the viewer's (pullRequestListedGroup), so a GitCafe pull request matched by actor is not dropped. Web gets the same result from its partitions' groups.involved. It is inPullRequestInvolvement. The provider flaglistsInvolvedis set by GitHub, which narrowsinvolvedwithinvolves:<viewer>.PullRequestServiceanswersinvolvedwith nothing for other providers, without a forge request, so those projects' rows come from the authored and review-requested reads.involves:<viewer>(author, assignee, mentions, commenter). It does not fall back to the repository listing forinvolved, because that listing has no comment or mention data.az repos pr listhas only--creatorand--reviewer. Same as GitLab.ignoresInvolvementcheck above.PullRequestsPageruns a third partition query withinvolvement: "involved", only for the projects in scope on the rule, after the main list answers. Feeds without the rule send no extra request. Its rows join the feed like the authored and reviewing partitions, in the group their own author and review requests give. The main list's Load more and footer come from one helper,pullRequestLoadMore. A page in flight is never restarted. The list counts as failed only when no environment can continue, so one failed environment does not stop the others from paging. Settings and the row menu ("Feed for ") offer the rule.PullRequestsScreenreads one page of the involved, authored and review-requested lists, after the main list answers and not while searching. Their rows join the list, and pull to refresh refreshes them. Load more pages the main list only, as onmain.involvementtoall | reviewing | authored, and mobile's persisted controls pick those three literals.pullRequestFeedInvolvedenvironment capability gates the option. Web Settings, the web row menu and mobile Settings hide "Involving me" unless every server that the write goes to sends it, so an older server never holds the rule or receivesinvolvement: "involved". A stored unknown rule now decodes toall, and to an absent project override. A settings write still rejects an unknown rule.docs/user/source-control.md› "Choose what the list shows" names the rule, the GitHub-only extra coverage, the one-page limit, and the search behaviour.Scope
The maintainer of this fork asked for this feature in a delegated T3 Code task (follow-up to #31). It is not a bug fix.
Verification
packages/client-runtime/src/pullRequestFeed.test.ts: table rows forinvolvedunder each group;pullRequestFeedVisibilityrows for theinvolvedcallback; the matcher (listed rows show, unlisted rows of a ready project do not, a project that is not ready shows every row, and no answer during a search shows every row); a GitCafe row listed as authored by actor stays authored. 31 tests pass.apps/web/src/components/pullRequest/pullRequestLoadMore.logic.test.ts: one row per main-list state, and the per-environment failure rule (one failed environment while others continue, and none that can continue). 9 tests pass.apps/web/src/components/pullRequest/pullRequestList.logic.test.ts: an involved row the list has not reached joins Others once, in recency order. Both web files: 55 tests pass.packages/contracts/src/settings.test.ts: an unknown stored rule decodes toalland to an absent override;involvedround-trips; a write with an unknown rule fails. 34 tests pass.packages/source-control-github: theinvolvedsearch query isis:pr is:open involves:bilal sort:updated-desc repo:acme/web. The search-free fallback does not read the repository listing forinvolved, and fails when the empty batch was truncated. An emptyinvolvedread is an answer in a covered repository and fails in an uncovered one. 160 tests pass.apps/server/src/pullRequest/PullRequestService.test.ts:involvedis read only from a provider withlistsInvolved. The login check drops another author's row only for a provider withignoresInvolvement, and keeps it otherwise (the GitCafe case). 128 tests pass.apps/mobile/src/features/pull-requests/pullRequestList.test.ts: 24 tests pass.8bac659, dev server withpingdotgg/t3codeandpnupu/t3codeprojects): settingpingdotgg/t3codeto Involving me drops its 97 "Others" rows and keeps fix(triage): file labeled reports through the issue template pingdotgg/t3code#31321, the only open PR there thatgh search prs --involves @mereturns. The baseline is the same build with the project on All pull requests, which is whatmainshows; I did not capturemainitself.Before: t3code project on All pull requests
Row menu: the new Involving me rule
After: t3code project on Involving me
vp run check:changedon8578a7a: lint, typecheck (41 packages), tests (23 files), react compiler (11 files) and graphql pass. Knip fails on the unusedscripts/fork/*files, and format fails on the untracked.jaru/map. Neither comes from this change, and I committed with--no-verifybecause of them.Not verified:
8bac659; for this scenario the feed is the same, so I did not capture again.involves:. The GitHub unindexed path and all mobile changes are typechecked, and unit-tested where the logic allows; I did not run them live.involved. No tag contains feat(pull-requests): per-project feed rules and hidden pull requests #31, so no released build has it.Review history:
858519c→9d05164): the feed was built around a cutoff matcher, which was then replaced by the source model.fdda035,afa8c65→a09e79c): providers that ignore involvement are filtered on the server; one failed environment no longer stops the main list; GitCafe rows matched by actor stay.a09e79c→8578a7a): the maintainer cut the paging of the involved, authored and review-requested listings, because those Load more paths drew most of the findings. The shoulds in the round-7 reviews were in that paging, except codex F3 (GitCafe rows matched by actor dropped on the client), which is fixed./code-review(medium) on the round-8 diff before the push: 2 Important findings, both declined. One-page reads hide involved rows past the page: that is the accepted, documented limit. A failed main-list continuation loses its cursor: removing the retry cursor was the maintainer's request, and the main list is back to howmainbehaves. Fixed nits: the cap wording, a stale comment, and a memo for mobile's listed groups. Mobile's secondary lists now read 99 rows, as web does. A pre-existing finding is listed below.Declined, follow-ups:
PULL_REQUEST_LIST_PROJECT_LIMITlater.involvedcontinuation (GitHub batched path).authoredandreviewing. The server check now covers that for every rule.Model and harness: Claude Opus 5.5 via T3 Code delegated task (Claude Code).
🤖 Generated with Claude Code