Skip to content

Swap to Air's native hand crafted parser - #1472

Merged
DavisVaughan merged 1 commit into
mainfrom
feature/parser-swap
Nov 6, 2026
Merged

DavisVaughan merged 1 commit into
mainfrom
feature/parser-swap

Conversation

@DavisVaughan

@DavisVaughan DavisVaughan commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

A very quiet PR all things considered, as it should be! Most of the lead up work has been done incrementally by #1466, #1468, #1469, #1470

Naively running the new benchmarks against main shows nice results. It's kind of hard to see, but 20-50% improvements in many cases.

davis@davisvaughan-01HQ ark % just bench-compare -- --baseline main
diagnostics/ctl.snap    time:   [154.38 µs 156.55 µs 158.90 µs]
                        change: [−1.1169% +0.7472% +2.6433%] (p = 0.47 > 0.05)
                        No change in performance detected.
diagnostics/ctl.cold    time:   [160.99 ms 162.97 ms 164.88 ms]
                        change: [−22.802% −21.492% −20.303%] (p = 0.00 < 0.05)
                        Performance has improved.
diagnostics/ctl.warm    time:   [5.3788 ms 5.5330 ms 5.7224 ms]
                        change: [−2.4856% +0.9061% +4.5577%] (p = 0.65 > 0.05)
                        No change in performance detected.
Found 2 outliers among 10 measurements (20.00%)
  1 (10.00%) high mild
  1 (10.00%) high severe
diagnostics/one.cold    time:   [159.45 ms 159.95 ms 160.41 ms]
                        change: [−24.829% −23.386% −22.127%] (p = 0.00 < 0.05)
                        Performance has improved.
diagnostics/one.warm    time:   [5.7891 ms 5.8515 ms 5.9265 ms]
                        change: [−5.0436% −2.5865% −0.2268%] (p = 0.06 > 0.05)
                        No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
diagnostics/one.edit    time:   [8.5234 ms 8.5622 ms 8.6017 ms]
                        change: [−16.942% −15.861% −14.731%] (p = 0.00 < 0.05)
                        Performance has improved.
diagnostics/one.open    time:   [11.964 ms 12.129 ms 12.284 ms]
                        change: [−2.3739% −0.4727% +1.5847%] (p = 0.66 > 0.05)
                        No change in performance detected.
diagnostics/one.symbol  time:   [14.594 ms 14.699 ms 14.809 ms]
                        change: [−57.709% −57.062% −56.467%] (p = 0.00 < 0.05)
                        Performance has improved.
diagnostics/burst       time:   [186.59 ms 188.69 ms 191.05 ms]
                        change: [−35.640% −34.367% −33.155%] (p = 0.00 < 0.05)
                        Performance has improved.

diagnostics/all.cold    time:   [289.21 ms 294.47 ms 299.43 ms]
                        change: [−18.710% −16.588% −14.488%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) low mild
diagnostics/all.warm    time:   [128.10 ms 132.00 ms 135.62 ms]
                        change: [−12.393% −8.2117% −3.6795%] (p = 0.00 < 0.05)
                        Performance has improved.

@DavisVaughan
DavisVaughan merged commit dd77190 into main Nov 6, 2026
19 checks passed
@DavisVaughan
DavisVaughan deleted the feature/parser-swap branch November 6, 2026 22:59
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant