Skip to content

Improve Composer input-mode switching and shortcut visibility - #455

Merged
powerfooI merged 1 commit into
mainfrom
fix/composer-mode-and-shortcuts
Oct 19, 2026
Merged

powerfooI merged 1 commit into
mainfrom
fix/composer-mode-and-shortcuts

Conversation

@powerfooI

Copy link
Copy Markdown
Owner

Summary

  • Coordinate visibility between the inline Composer shortcut keyboard (.terminal-composer-shortcuts) and the upper-right shortcut capsule (.terminal-mobile-keys) so shortcut access stays discoverable when the Composer shortcut row is collapsed or covered by the command picker.
  • Preserve active editor/Direct terminal focus and expanded state when interacting with .terminal-mobile-keys and .terminal-mobile-side-shortcuts.
  • Keep Direct <-> Composer switching coherent across button clicks, direct textarea focus, and temporary Commands transitions: reset expanded and clear inline height when leaving Composer or emptying the draft, zero minHeight during scrollHeight content measurement so inverse UI scaling (--ui-scale < 1) does not falsely trigger data-expanded, ensure .terminal-composer .terminal-composer-input:focus overrides closed-bar styling, and gate header/tabbar/pane-switcher collapse on &.keyboard-open consistently across Direct and Composer modes.

Fixes #448

Verification

  • bun test web/src/components/TerminalComposer.test.ts web/src/components/TerminalComposer.dom.test.ts web/src/components/TerminalComposer.uploads.test.ts web/src/components/TerminalView.inputMode.test.ts web/src/components/MobileBottomBar.layout.test.ts web/src/components/useMobileControlsDrag.keyboard.test.ts
  • bun run format:check
  • bun run lint
  • bun run typecheck:bun
  • bun run build:web

@powerfooI powerfooI added the bug Something isn't working label Oct 19, 2026
@powerfooI

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T08:06:36.605522Z a569458 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: a5694589d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@powerfooI
powerfooI merged commit 2b5d883 into main Oct 19, 2026
5 checks passed
@powerfooI
powerfooI deleted the fix/composer-mode-and-shortcuts branch October 19, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Composer input-mode switching, shortcut visibility, and focus coordination

1 participant