Repository navigation
Fix rollbacks after failed commits - #1178
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 052b3b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simolus3
marked this pull request as ready for review
October 27, 2026 14:36
Chriztiaan
approved these changes
Oct 27, 2026
Chriztiaan
reviewed
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
COMMITfor a transaction fails, we issue aROLLBACKstatement instead to revert the transaction. BecauseTransactionImplementationcan only issue one of those statements however, therollback()call had no effect. This avoids the issue by running theROLLBACKstatement directly against the underlying context.A similar issue exists in the Kysely driver, where we've always resolved the
writeTransaction()callback. Kysely callsrollbackTransaction()if a priorcommitTransactioncall failed, our current setup there setsthis.#tx = nulltoo early and swallows the error. For consistency, this changes the Kysely implementation to forward errors as well.Closes #1176.
AI use: Claude found the Kysely issue while reviewing the other change, I also used Claude to fix it.