basic typing - #100
Open
Vulwsztyn wants to merge 1 commit into
Open
Conversation
Author
|
@ppannuto Might I ask that you take a look when you have a moment? |
Owner
|
Sorry I really don't do much but maintain bugfixes for this library these days — what's the purpose of this? What's the backwards-compatibility implications? Lots and lots of random projects use this, so it's pretty sensitive to anything that would trip up older python versions |
Author
|
Hi, given your explanation I decided not to potentially introduce breaking changes into your lib, but to contribute the types to typeshed. This PR can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces basic typing. Changes no behaviour.