-
Notifications
You must be signed in to change notification settings - Fork 999
Fix Prisma dev commands and typos in documentation #8384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -39,7 +39,15 @@ prisma dev [options] | |||||||||||
| ### Start a local Prisma Postgres server | ||||||||||||
|
|
||||||||||||
| ```npm | ||||||||||||
| npx prisma dev | ||||||||||||
| npx prisma devnpm install prisma tsx @types/pg --save-dev | ||||||||||||
| npm install @prisma/client @prisma/adapter-pg dotenv pg | ||||||||||||
| npx prisma init | ||||||||||||
|
|
||||||||||||
| # Add this to .env | ||||||||||||
| DATABASE_URL="postgres://5d1ce24737c0027644adca72d4aa610a57fdc4c1628c07a04e58c05f1e359871:sk_w63bXxCc9NFk8PMZoiXNp@pooled.db.prisma.io:5432/postgres?sslmode=require" | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Use the connection URL for the local server. Line 47 points 🧰 Tools🪛 Betterleaks (1.8.1)[high] 47-47: Detected a password embedded in a service connection URI, which may expose direct access to the referenced service. (generic-credential-uri) 🤖 Prompt for AI Agents |
||||||||||||
|
|
||||||||||||
| npx prisma migrate dev --name init | ||||||||||||
| npx prisma generate | ||||||||||||
| ``` | ||||||||||||
|
|
||||||||||||
| Output: | ||||||||||||
|
|
@@ -56,14 +64,11 @@ Output: | |||||||||||
|
|
||||||||||||
| ### Start with a specific name | ||||||||||||
|
|
||||||||||||
| Create a named instance for project isolation: | ||||||||||||
|
|
||||||||||||
| ```npm | ||||||||||||
| npx prisma dev --name="mydbname" | ||||||||||||
| Create a namedinstance for project issolation: | ||||||||||||
| ```nnpmnpx prisma dev --name="mmydbname | ||||||||||||
|
Comment on lines
+67
to
+68
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Restore a valid named-instance example. Line 68 puts the command in the code-fence opener, so the block does not show a runnable command. Line 67 also misspells “named instance” and “isolation.” Restore the sentence and a separate command block. (docs.prisma.io) Proposed correction-Create a namedinstance for project issolation:
-```nnpmnpx prisma dev --name="mmydbname
+Create a named instance for project isolation:
+```npm
+npx prisma@7 dev --name="mydbname"📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[grammar] ~67-~67: Ensure spelling is correct (QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1) 🤖 Prompt for AI Agents |
||||||||||||
| ``` | ||||||||||||
|
|
||||||||||||
| ### Run in detached mode | ||||||||||||
|
|
||||||||||||
| ### Run in detached mmode | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Correct the detached-mode heading. Line 71 misspells “mode” as “mmode.” Proposed correction-### Run in detached mmode
+### Run in detached mode📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[grammar] ~71-~71: Ensure spelling is correct (QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||||||||||||
| Run the server in the background: | ||||||||||||
|
|
||||||||||||
| ```npm | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Separate installation from starting the server.
Line 42 joins
npx prisma devandnpm installinto one malformed command. Also,prisma devstays in the foreground, so later setup commands cannot run in the same terminal until the server stops. Install and initialize first. Then start the server in a separate terminal before running migrations. The Prisma local-development instructions use a separate terminal for migrations. (prisma.io)🤖 Prompt for AI Agents