Repository navigation
Fix GPU runbook: neural path must not import joblib - #36
Merged
Merged
Conversation
The transformer trainer imported its provenance helpers from the CRF module, which imports joblib, so the GPU runbook (neural extra only) failed at its first experiment. The helpers move to models/provenance.py. A test imports the neural training and prediction modules with baseline and serving packages blocked. Re-running the runbook reuses its venv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleNotFoundError: No module named 'joblib'. The transformer trainer importedtraining_hash/training_originsfrom the CRF module, which imports joblib, scikit-learn and python-crfsuite, and the runbook installs only theneuralextra.triggermap/models/provenance.py, which has no learner dependencies. CRF and transformer both import them from there; outputs are unchanged.joblib,sklearn,pycrfsuite,spacy,fastapi,uvicornandonnxruntimeblocked. It fails without the fix with the same error.run_neural.shreuses an existing.venv-gpuon re-runs (--allow-existing).Checks
ruff check,ruff format --check,mypy src/,pytest -m "not slow"(236 passed);shellcheckclean.