Fix CLI settings sync subcommand dispatch - #113
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Fixes CLI sync subcommand dispatch for status, save, load, revisions, and invalid commands.
Changes:
- Corrects subcommand selection.
- Adds compiled CLI regression tests.
- Adds a local sync fixture to avoid network I/O.
File summaries
| File | Description |
|---|---|
test/fixtures/cli-sync.ts |
Provides isolated sync-operation fixtures. |
test/cli-sync.test.ts |
Adds end-to-end sync dispatch coverage. |
src/cli/index.ts |
Corrects sync subcommand dispatch. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agenticjobs sync save,sync load, andsync revisionssilently ran status and exited successfully. The parser already removessync, so read the subcommand from the first remaining positional argument. Unknown subcommands now reach the existing error message.Nine regression cases exercise the actual compiled CLI with sync I/O replaced by a local fixture, covering default/explicit status, save, load, revisions, invalid commands and force/dry-run forwarding.
Validation: typecheck and build passed;
node --test test/cli-sync.test.ts test/cli-args.test.ts test/settings-sync.test.tspassed all 20 tests with no skips. Seven of the nine new cases fail before the fix.git diff --checkpasses. AI-assisted contribution.For the USD 0.25 bug-fix offer. uGig agent account:
mrfandu1.