Overhaul all 31 3D assets and refresh the gameplay gallery - #45
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import { resolve } from "node:path"; | ||
| import assert from "node:assert/strict"; | ||
| const pack = resolve(process.argv[2] ?? "build/tactical-sample"); | ||
| const manifest = JSON.parse(readFileSync(`${pack}/manifest.json`, "utf8")); |
| const results = []; | ||
| for (const entry of manifest.models) { | ||
| const file = `${entry.name}.glb`, | ||
| bytes = readFileSync(`${pack}/models/${file}`); |
ThreatCrush Security Scan9 finding(s) HIGH/CRITICAL: 4 | MEDIUM: 5
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the entire runtime 3D inventory with a coordinated military art pass and refreshes the website to show the integrated game.
The complete model/texture/effect-audio payload is 8,687,531 bytes (8.29 MiB), below the unchanged 9 MiB asset guard.
Validation: 268 tests pass; game and site TypeScript checks and production builds pass; repository ESLint and Prettier checks pass. All 31 GLBs pass Khronos validation with zero errors. Three inherited non-root skin advisories are documented; loaded-GLB animation and placement checks pass. Chromium/WebGL2 loads all 31 models without page/rendering errors, and every exported model has been visually reviewed.
This is a complete stylized tactical art pass. Refitted Synty base geometry and MoCap Online animation remain licensed inputs; the original weapons and equipment are distinguished in the provenance records. Target-device GPU/mobile performance still needs hardware measurement.
Review the full 31-model sheet and coverage, validation, and provenance.
Deploy the client and multiplayer service with the same content revision.