Skip to content

fix(dns): answer A/AAAA by question type, NODATA with SOA, NS at zone apex - #1485

Merged
Mzack9999 merged 2 commits into
devfrom
fix/1484-dns-qtype
Oct 23, 2026
Merged

Mzack9999 merged 2 commits into
devfrom
fix/1484-dns-qtype

Conversation

@dogancanbakir

Copy link
Copy Markdown
Member

Fixes #1484

  • A/AAAA/ANY answers follow the question type; CNAME and mismatched types get NODATA with the apex SOA (TTL 3600, so it is negatively cached).
  • AUTHORITY NS records are owned by the matching configured domain, which also fixes names under a second -domain getting the first domain's nameservers.
  • Three existing tests sent no question but expected both families; they now ask ANY/AAAA explicitly.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 2e5f0325-ae2f-4aa3-9660-af72fb153758

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Mzack9999
Mzack9999 merged commit e88c5fd into dev Oct 23, 2026
9 checks passed
@Mzack9999
Mzack9999 deleted the fix/1484-dns-qtype branch October 23, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants