[Mzack9999]

Closes #1499

Proposed changes

The secret check used for poll, deregister and upload now fails when the stored secret or the given secret is empty. Shared buckets created by the server (root-TLD domains, the token bucket) have no secret, so clients can no longer change them. The same check is used in the in-memory and the Redis storage.

Proof

New tests TestSharedBucketGuardInMemory, TestSharedBucketGuardRedis and TestEmptySecretNeverMatches. pkg/storage tests pass.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: d1294f22-f83e-4ee2-a519-0c170844acaa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}