Repository navigation
fix(dns): MX, NS and SOA answers use the queried domain's hosts - #1502
Merged
Mzack9999 merged 1 commit intoOct 30, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Mzack9999
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1501
-domainentries,handleMX,handleNS, andhandleSOAperformed an exact match on the queried name againstmxDomains/nsDomains, falling back toDomains[0]if not matched. As a result:x.example.org MX) returned the first domain's hosts (mail.example.com).EXAMPLE.ORG NS) missed the map lookup due to case sensitivity and returned the first domain's nameservers.handleMX,handleNS, andhandleSOAto usezoneApex, matching the behavior ofresultFunctionfrom fix(dns): answer A/AAAA by question type, NODATA with SOA, NS at zone apex #1485. This ensures the correct, case-insensitive zone apex is selected for each domain (including nested domains likesub.example.com).TestDNSServerMXNSSOAPointToQueriedDomaincovering exact MX, NS, and SOA records across multiple domains, mixed-case queries, and nested domains.Tested with:
go test -race ./pkg/...go vet ./pkg/server/golangci-lint run ./pkg/server/...