Repository navigation
fix(dns): record the query type of every DNS interaction - #1504
Merged
Mzack9999 merged 1 commit intoOct 31, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Mzack9999
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1503
toQTypepreviously hardcoded only 8 query types (A, NS, CNAME, SOA, PTR, MX, TXT, AAAA). Interactions for any other query type (HTTPS, ANY, CAA, SRV, etc.) were saved with an emptyq-type. As a result,interactsh-clientprintedReceived DNS interaction ()and omitted the field in-jsonoutput.toQTypewithdns.Type(qtype).String()frommiekg/dns. This preserves the existing 8 type names, adds mnemonics for all standard DNS types, and falls back toTYPE<n>for unassigned/private types.TestDNSInteractionQueryTypeverifying stored interaction query types across standard, extended, and unassigned types.Tested with:
go test -race ./pkg/...go vet ./pkg/server/golangci-lint run ./pkg/server/...