Skip to content

fix(dns): record the query type of every DNS interaction - #1504

Merged
Mzack9999 merged 1 commit into
projectdiscovery:devfrom
antcybersec:fix/dns-interaction-qtype
Oct 31, 2026
Merged

Mzack9999 merged 1 commit into
projectdiscovery:devfrom
antcybersec:fix/dns-interaction-qtype

Conversation

@antcybersec

Copy link
Copy Markdown

Fixes #1503

  • toQType previously hardcoded only 8 query types (A, NS, CNAME, SOA, PTR, MX, TXT, AAAA). Interactions for any other query type (HTTPS, ANY, CAA, SRV, etc.) were saved with an empty q-type. As a result, interactsh-client printed Received DNS interaction () and omitted the field in -json output.
  • Replaced toQType with dns.Type(qtype).String() from miekg/dns. This preserves the existing 8 type names, adds mnemonics for all standard DNS types, and falls back to TYPE<n> for unassigned/private types.
  • Added TestDNSInteractionQueryType verifying stored interaction query types across standard, extended, and unassigned types.

Tested with:

  • go test -race ./pkg/...
  • go vet ./pkg/server/
  • golangci-lint run ./pkg/server/...

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2dffe9cb-1455-49eb-9c13-cecba7525d23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Mzack9999
Mzack9999 merged commit 3c4146e into projectdiscovery:dev Oct 31, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNS interactions for HTTPS, ANY, CAA, SRV and other query types are stored with an empty q-type

2 participants