review: modern Go in the pod filter and the exec arg stop - #133
Merged
Conversation
strings.CutSuffix replaces the HasSuffix-and-slice pair that stripped a percent sign, and the exec command's StopOnNthArg takes new(1) instead of a package-level variable that existed only to be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style round under the reloaded asl (rules commit 2b26bf9) and the reloaded /code skill; 99 files read in full by readers, two findings kept after adjudication:
strings.CutSuffixreplaces the HasSuffix-and-slice pair that strips a percent sign in the pod resource filter, and the exec command'sStopOnNthArgtakesnew(1)instead of a package-level variable that existed only to be addressed. No behavior change. Gates: build, vet, full tests, lint + fmt-check on linux and darwin, asl gate analyzers on both, all green; comments +0 −0.