Repository navigation
sync: merge main (0.1.34) into refactor/clean-kitchen - #3423
Merged
Merged
Conversation
…isual-rules-3380 docs(skills): guide pdd-product adapters, user-goal Stories and visual checks (#3380)
…ng-controls fix(svg-layout): scope control warnings per view on multi-drawing prompts (#3394)
docs: identify product plan checks before Story tests
…d remove local runtime copy
…d untested Story entries
…-3193 feat(runtime): switch runtime seam to @promptdriven/runtime-client
… review items Refs #3252
…li-3252 # Conflicts: # prompts/cli/pdd-cli.prompt.md # prompts/cli/public-boundary.prompt.md # src/agent-adapters.mjs # src/autopilot-core.mjs # src/command-catalog.mjs # src/pdd-cli.mjs # test/autopilot-launcher.test.mjs
…nrollment per provider (#3252)
…l_cooling enrollment (#3252)
feat(accounts): add Cloud accounts CLI, step isolation overlay, and Stick-Until-100% rotation
…nd offline net/credit guards (#3420) * feat(autopilot): harden runtime paperwork sync, slot cleanup, suite concurrency, and offline/credit guards * fix(autopilot): read PDD_CHECK_CPUS only from explicit ports.env * Address Round 1 review findings on process cleanup, per-test skip checks, credit guards, and npm test net guard * Bound runStepAgentProcess Cloud lease loop on repeated or missing-ID credit accounts * Copy test-net-guard.mjs into synthetic package.json fixture in test-session-isolation.test.mjs
Main moved Runtime from src/runtime/ into the installed package @promptdriven/runtime-client and removed pdd interface draft and approve --automatic (#3417). test/runtime-seam.test.mjs conflicted in 5 hunks, all in SEAM5. The data block and the inline probe code stay out, because SEAM5 keeps its record in test/fixtures/seam-loads.txt and its probes in test/helpers/seam-loads.mjs. Main's package logic is ported: - the static graph reads the package files under src/runtime/ names and maps the package specifier to src/runtime/index.mjs (main's code); - the probe analyzer names what the seam loads from outside src/ the same way, so the helper never names the package (SEAM24); - rejected modules map back to their package files; - the interface-draft and approve --automatic probes and guards are gone, as on main, and so is the setup guard; - the heavy-module guard drops runtime/interface-draft.mjs, which the package no longer has. The regenerated record changes 17 lines, all from main's imports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The seam now re-exports Runtime names from an installed package, not from src/runtime/. Mark exports whose name comes from a package specifier and skip them, as the report already skips src/runtime/ re-exports. Test-only exports on the merged tree go from 92 to 32 (base 32). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main's setup check rejected only interface-draft.mjs, which is gone. The derived guard from #3392 is wider: it rejects each module that pdd setup loads beyond --help (15 modules on this tree), and each run still exits 1 with REVIEW_LOAD_FAILURE in stderr. Restore it as it was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges
origin/main(0.1.34, 27 commits) intorefactor/clean-kitchen. It is a merge commit, with no rebase and no force push. Two main changes matter here:src/runtime/into the installed package@promptdriven/runtime-client(feat(runtime): switch runtime seam to @promptdriven/runtime-client #3418).pdd interface draft, local interface drafting andpdd approve --automatic.Only
test/runtime-seam.test.mjsconflicted, in 5 hunks, all inside SEAM5. Main rewrote SEAM5 inline, while #3392 had moved its probes totest/helpers/seam-loads.mjsand its data totest/fixtures/seam-loads.txt.Lines
refactor/clean-kitchen: +7,804 / -70,110 lines in 580 files. Almost all of this is main. For example, main deletedsrc/runtime/andtest/runtime-package/.test/runtime-seam.test.mjs: +10 / -10test/helpers/seam-loads.mjs: +14 / -12test/tools/ratchet.mjs: +6 / -2 (its own commit)test/fixtures/seam-loads.txt+4 / -13 (fromnode test/tools/record-seam-loads.mjs).How each hunk was resolved
I resolved each hunk by hand. No side was taken whole.
BASE_SRC_CATALOGandRECORDED_BASE_ENTRIESdata (78 lines)pkgRuntimeDirandstaticFiles. Tarjan stays in the helper.ASYNC_SEAM_BRIDGE_PROBES, analyzer andrunProbe(68 lines)approve --automatic.The lines around the hunks auto-merged to main's version. These include
ALLOWED_BASE_CYCLESwithout the interface-draft cycle,coveredLocalswithaccountsand withoutinterface-draft, andACYCLIC_ENTRIESwithoutcli:interface-draft.Main's Runtime logic in the helper-based SEAM5
node_modules/@promptdriven/runtime-client/src/runtime/*.mjsundersrc/runtime/names, and the specifier'@promptdriven/runtime-client'gives an edge tosrc/runtime/index.mjs.runtime/index.mjs, and the package'ssrc/runtime/x.mjsbecomesruntime/x.mjs(src/runtime/x.mjsin the cycle strings).src/runtime-seam.mjsloads from outsidesrc/, so the helper never writes the package name. SEAM24 forbids that name in every test file excepttest/runtime-seam.test.mjs, and SEAM1 makes the seam the only importer of the package.runtime/...name.runtime/index.mjsrejects both the package entry and itssrc/runtime/index.mjs. The light-entry checks now also reject package modules outside the record.ASYNC_SEAM_BRIDGE_PROBESis as on main (noapprove-automaticentries).cli:interface-draft,cli:approve-automaticandcli:approve-automatic-testsare dropped, because the commands are gone. Their guards are dropped too.setupguard kept (review fix). Main's check rejected onlyinterface-draft.mjs, which is gone. The test: make layout-sensitive tests safe for file moves and splits #3392 guard is wider: it rejects each of the 15 modules thatsetuploads beyond--help, one at a time. Every run still exits 1 withREVIEW_LOAD_FAILUREin stderr. An earlier head of this PR dropped this guard by mistake.SEAM_LOAD_BASES,test,lint,simulateandmcpnow haveproduct statusas their base. Their old base,approve --automatic, is gone.src/runtime/interface-draft.mjs, because the package has no such file any more.src/runtime/runtime-client.mjsandsrc/runtime/runtime-output.mjsnow come from the package under the same names.Every changed record line
-cli:interface-draft …(6 lines)pdd interface draft.-cli:approve-automatic runtime-exit.mjs--automatic.+cli:test,+cli:lint,+cli:simulate,+cli:mcpruntime-exit.mjsruntime-exit.mjsbefore, through their old baseapprove --automatic. Now their base isproduct status, so the line is written for each command.-cli:setupruntime/contract-refs.mjs,runtime/interface-draft.mjs,runtime/runtime-markdown.mjs,runtime/runtime-preflight.mjs,runtime/scenario-json.mjspdd setuprandraftInterfaces({ all: true })through a lazy seam import (src/pdd-cli.mjs:336), and #3417 removed it.-lib:product.mjs runtime/interface-draft.mjsinterface-draft.mjs, soruntime-bindingsno longer loads it. Main also dropped theinterface-draft <-> runtime-bindings <-> runtime-client <-> runtime-slotscycle. This one line covers every probe based onlib:product.mjs.Cross-check. I expanded the new record and folded it the old way (
src/runtime/x→src/x, the old skip list). It equals main's own updatedRECORDED_BASE_ENTRIESfor all 47 entries, so the record takes in no load change that main did not record itself. The generator gave the same record in 3 runs.Other refactor tools on the merged tree
test/tools/ratchet.mjsruns (exit 0) against the clean-kitchen base.TEST_SCHEMA,tarFilesandwithExactIntegers. The report skipssrc/runtime/re-exports, but not names from a package specifier.accounts-cli.mjsis new from main. The other 5 were already missing on the base.test/golden/run.mjs capture: 34 of 34 cases were captured on base and head. 30 are identical. The 4 that differ all come from main:cli-version:0.1.32→0.1.34.workflow-run-start:cliVersioninstatus.json,0.1.32→0.1.34.cli-help: theinterface draft,test --fill-hashandapprove --automaticlines are gone (Remove local Runtime interface block authoring, drafting, and instructions #3417). Thefilesandapprovedescriptions drop "Runtime interface". 16pdd accountslines are new (feat(accounts): add Cloud accounts CLI, step isolation overlay, and Stick-Until-100% rotation #3419). Theautopilot startdescription changed.approve-said-stdin: the 18-line "Contract coverage (review evidence)" block is gone. That code lived insrc/runtime/interface-draft.mjs, which main removed.Focused tests (laptop)
The package was installed with
npm ci --ignore-scripts.test/runtime-seam.test.mjstest/new-command-names.test.mjstest/name-the-interpreter.formal.test.mjstest/skills.test.mjstest/session-skills.test.mjs,test/skill-frontmatter.test.mjsI did not run the full suite, and I did not queue the VM suite. Do not merge until the lead does.
Note: main deleted
test/runtime-package/. The two wording-scan copies listed "For Ishaan" in #3392 are gone with it.🤖 Generated with Claude Code