Make server callbackUri optional for DC API requests with expectedOrigins - #52
Merged
Merged
Conversation
…gins Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
frostevent
enabled auto-merge (squash)
September 24, 2026 13:43
frostevent
disabled auto-merge
September 24, 2026 13:43
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signedDcApiRequestwithexpectedOriginsnever readsconfig.callbackUri, so clients had to configurecallbackUri: ""just to satisfy the type checker.ServerClientConfig.callbackUriis now optional. The frontendClientConfiginproof-vc-commonstill requires it.authorizationUrlandsignedAuthorizationRequestreject with a clear error whencallbackUriis missing.signedDcApiRequestrejects when neitherexpectedOriginsnorcallbackUriis provided.signedRequestis nowasync, sosignedAuthorizationRequestreturns a rejected promise instead of throwing synchronously when its params are invalid.expectedOriginsvs.callbackUrifor DC API requests.Existing clients that pass
callbackUriare unaffected.Tests
expectedOriginsand nocallbackUrisucceeds; DC API with neither is rejected;authorizationUrl/signedAuthorizationRequestwithoutcallbackUriare rejected.yarn testandyarn check-allpass.🤖 Generated with Claude Code