Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Owner
Author
|
Closing rather than merging: the fix is already on PR #135 proposed replacing the interpolated dashboard startup log with a logger("Dashboard started");GitHub Code Scanning alert #4 ( Deleting the branch and this draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/psam21/ns/security/code-scanning/4
To fix this without changing functionality, keep dashboard startup logging but remove any interpolation of sensitive or secret-derived values (
passwordand ideally username too, depending on policy strictness).Best single fix in
blossom/src/index.tsis to replace line 249 with a constant, non-sensitive message.blossom/src/index.tslogger(\Dashboard started with username=${config.dashboard.username} (password length: ${password.length})`);with a static message likelogger("Dashboard started");`No imports, helper methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.