Conversation
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
dzdidi
marked this pull request as draft
September 25, 2026 15:28
dzdidi
marked this pull request as ready for review
September 25, 2026 21:27
dzdidi
marked this pull request as draft
September 25, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: propagate Paykit cancellation through verification
Summary
Propagates Paykit Payment Request cancellation and expiry through Locks verification, public APIs, SDKs, and browser examples.
cancelledandexpired.cancelled.v0.1.0-rc6.Lifecycle mapping
cancelledcancelledexpiredexpiredProtocol validation
Locks accepts terminal Paykit responses only when they use canonical tuples:
{ "status": "cancelled", "confirmations": 0, "amount_matched": false }{ "status": "expired", "confirmations": 0, "amount_matched": false }Unknown fields, unknown statuses, or malformed terminal tuples remain dependency/protocol failures. They do not falsely terminalize verification.
Persistence and worker behavior
cancelledtoVerificationTaskStatus.0010_verification_task_cancelled_status.sql.cancelledin memory and PostgreSQL repositories.SDK and example behavior
cancelledandexpiredas distinct states.cancelled,expired, orfailed.Release preparation
0.1.0-rc5to0.1.0-rc6.Cargo.lock.@synonymdev/locks-sdkfrom0.1.0-rc5to0.1.0-rc6.rcdist-tag.Verification
Passed locally:
cargo test --workspace -- --skip infrastructure::postgres:: npm run smoke:examples --prefix locks-sdk/bindings/js cargo check --locked --workspace --all-targets cargo clippy --locked --workspace --all-targets --all-features -- -D warnings cargo fmt --all -- --check git diff --checknpm release checks also passed:
Generated package was validated as:
PostgreSQL-backed runtime tests were not executed locally because
TEST_DATABASE_URLwas unset.Related PR
Pairs with Paykit Server support for:
RejectedorCanceled→cancelledProposalExpired→expiredFor deployment, Locks should be updated before or together with Paykit Server so it understands the new terminal response status before Paykit begins returning it.