Use proper types in pbpal_check_tls for C++ builds - #257
Merged
Merged
Conversation
`pbpal_check_tls` in OpenSSL and mbedTLS backends stored `pbpal_handle_socket_condition` result in `int` and passed it to `pubnub_res_2_string(enum pubnub_res)` which is a hard error in C++.
parfeon
added
status: done
Contributor
Author
|
@pubnub-release-bot release |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cpp-compat): use proper types in
pbpal_check_tlsfor C++ buildspbpal_check_tlsin OpenSSL and mbedTLS backends storedpbpal_handle_socket_conditionresult inintand passed it topubnub_res_2_string(enum pubnub_res)which is a hard error in C++.