Skip to content

Refuse the screen resolution setting on non-Pro 2.5.4, add type and gop - #69

Merged
chiconws merged 1 commit into
devfrom
screen-resolution-removed-2.5.4
Nov 11, 2026
Merged

chiconws merged 1 commit into
devfrom
screen-resolution-removed-2.5.4

Conversation

@chiconws

@chiconws chiconws commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

NanoKVM 2.5.4 (CHANGELOG) removed the manual resolution setting. The video now follows the HDMI input, and POST /vm/screen validates type against type|fps|quality|gop.

  • set_screen(ScreenSettingType.RESOLUTION, ...) raises NanoKVMNotSupportedError from 2.5.4 and still sends the request below it.
  • ScreenSettingType gains TYPE (0 = MJPEG, any other value = H.264) and GOP (1-100, otherwise 30). The firmware has accepted both since 2.3.
  • docs/api.md notes the version limit.

Tests: pytest 521 passed, including a new test for both sides of 2.5.4.

…d gop

NanoKVM 2.5.4 removed the manual resolution: the video follows the HDMI
input, and POST /vm/screen now validates type against
type/fps/quality/gop, so a resolution request fails on the device.
set_screen raises NanoKVMNotSupportedError for it from 2.5.4 and still
sends it below. ScreenSettingType gains TYPE and GOP, which the firmware
has accepted since 2.3.
@chiconws
chiconws merged commit 5669120 into dev Nov 11, 2026
2 checks passed
@chiconws
chiconws deleted the screen-resolution-removed-2.5.4 branch November 11, 2026 02:37
@chiconws chiconws changed the title Refuse the screen resolution setting on non-Pro 2.5.4, add type and gop Support non-Pro 2.5.3 and 2.5.4: media API, permissions, virtual device state, screen settings Nov 11, 2026
@chiconws chiconws changed the title Support non-Pro 2.5.3 and 2.5.4: media API, permissions, virtual device state, screen settings Refuse the screen resolution setting on non-Pro 2.5.4, add type and gop Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant