Repository navigation
Refuse the screen resolution setting on non-Pro 2.5.4, add type and gop - #69
Merged
Merged
Conversation
…d gop NanoKVM 2.5.4 removed the manual resolution: the video follows the HDMI input, and POST /vm/screen now validates type against type/fps/quality/gop, so a resolution request fails on the device. set_screen raises NanoKVMNotSupportedError for it from 2.5.4 and still sends it below. ScreenSettingType gains TYPE and GOP, which the firmware has accepted since 2.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NanoKVM 2.5.4 (CHANGELOG) removed the manual resolution setting. The video now follows the HDMI input, and
POST /vm/screenvalidatestypeagainsttype|fps|quality|gop.set_screen(ScreenSettingType.RESOLUTION, ...)raisesNanoKVMNotSupportedErrorfrom 2.5.4 and still sends the request below it.ScreenSettingTypegainsTYPE(0 = MJPEG, any other value = H.264) andGOP(1-100, otherwise 30). The firmware has accepted both since 2.3.docs/api.mdnotes the version limit.Tests:
pytest521 passed, including a new test for both sides of 2.5.4.