Repository navigation
Conversation
Domain.default_content_guard was a ForeignKey on the Domain row. Store the mapping in a new DomainDefaultContentGuard table instead, scoped to the domain through pulp_domain, so it lives next to the content-guard it references. This avoids a cross-database relation once domains can live in separate databases. The REST API is unchanged. Domain.default_content_guard is now a read-only property, and Domain.set_default_content_guard() sets or clears it. Existing values are migrated, and deleting a content-guard still clears it as the domain's default. Closes pulp#8303
Contributor
Author
|
/retest |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domain.default_content_guard was a ForeignKey on the Domain row. Store the mapping in a new DomainDefaultContentGuard table instead, scoped to the domain through pulp_domain, so it lives next to the content-guard it references. This avoids a cross-database relation once domains can live in separate databases.
The REST API is unchanged. Domain.default_content_guard is now a read-only property, and Domain.set_default_content_guard() sets or clears it. Existing values are migrated, and deleting a content-guard still clears it as the domain's default.
Closes #8303
📜 Checklist
See: Pull Request Walkthrough